Skip to content

Conversation

@HamidH97
Copy link
Contributor

@HamidH97 HamidH97 commented Dec 16, 2025

Fixes #

Description of the Change

This PR improves lookup performance in OAuth2Validator._get_token_from_authentication_server by using the indexed token_checksum field instead of the unindexed token field.

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS
  • tests/app/idp updated to demonstrate new features
  • tests/app/rp updated to demonstrate new features

@HamidH97 HamidH97 changed the title fix: use token_checksum for lookup in _get_token_from_authentication_… fix: use token_checksum for lookup in _get_token_from_authentication_server Dec 16, 2025
@HamidH97 HamidH97 force-pushed the fix/access-token-update-or-create-lookup branch 2 times, most recently from 1238fcd to 95c8912 Compare December 16, 2025 17:06
@n2ygk n2ygk self-requested a review December 16, 2025 17:49
Copy link
Contributor

@n2ygk n2ygk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks for this.

Please wait on #1631 to get merged by @dopry and then rebase this PR to resolve the broken check.

@n2ygk n2ygk force-pushed the fix/access-token-update-or-create-lookup branch from 95c8912 to 5383ce4 Compare January 8, 2026 19:17
@n2ygk n2ygk merged commit b8f4d5b into django-oauth:master Jan 8, 2026
25 checks passed
@codecov
Copy link

codecov bot commented Jan 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants