Skip to content

test: add failing test for redirect URI case sensitivity #1632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
webjunkie wants to merge 2 commits into from
Closed

test: add failing test for redirect URI case sensitivity #1632

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
15abc07
test: add failing test for redirect URI case sensitivity
webjunkie Jan 7, 2026
b0c2e73
fix: Make comment more precise
webjunkie Jan 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions tests/test_models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -718,6 +718,24 @@ def test_redirect_to_uri_allowed_expects_allowed_uri_list():
assert redirect_to_uri_allowed("https://example.com", ["https://example.com"])


def test_redirect_to_uri_allowed_case_sensitive():
"""
OAuth 2.0 Security Best Current Practice requires exact string matching for redirect URIs.
See: https://datatracker.ietf.org/doc/html/rfc9700#section-4.1.3

"the authorization server MUST ensure that the two URIs are equal"

This means https://EXAMPLE.COM should NOT match https://example.com
"""
# Exact match should work
assert redirect_to_uri_allowed("https://example.com/callback", ["https://example.com/callback"])

# Different case in hostname should NOT match (exact string matching required)
assert not redirect_to_uri_allowed("https://EXAMPLE.COM/callback", ["https://example.com/callback"])
assert not redirect_to_uri_allowed("https://example.com/callback", ["https://EXAMPLE.COM/callback"])
assert not redirect_to_uri_allowed("https://Example.Com/callback", ["https://example.com/callback"])


valid_wildcard_redirect_to_params = [
("https://valid.example.com", ["https://*.example.com"]),
("https://valid.valid.example.com", ["https://*.example.com"]),
Expand Down