Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

form validation benchmark added #45

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

deepakdinesh1123
Copy link
Contributor

No description provided.

@smithdc1
Copy link
Member

smithdc1 commented May 3, 2022

Hey @deepakdinesh1123

Thank you for the contributions here.

Maybe we should be adding these to the ASV repo as the primary way we wish for benchmarks to be run going forward? If we think ASV is useful, then we'll end up writing, and reviewing the benchmarks twice.

What do you think?

@deepakdinesh1123
Copy link
Contributor Author

I had thought of adding the benchmarks to this repo and getting them reviewed and then migrating all of them after making changes to the directory structure of the ASV repo but adding these benchmarks to the ASV repo sounds much better as I wouldn't have to write them twice. I was able to add the benchmark along with the existing benchmarks, I will add them to the ASV repo.

@smithdc1
Copy link
Member

smithdc1 commented May 5, 2022

I wouldn't have to write them twice.

Super :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants