-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed default puput blog main color to purple. #454
base: develop
Are you sure you want to change the base?
Conversation
Sorry @tim-schilling for the long long waiting, and thank you for helping me fixing my previous bug. |
That's a good question. I'm not 100% sure on what's the best practice, but the justification in mind is that those puput abstract models are not actual models. Because of that, we should put them in a separate file. That helps communicate these exist for a particular reason that's related to puput.
Not sure if you're asking why I'm renaming an abstract when one already exists. The reason is that the previous name was actually associated with the wrong base abstract model. I've now created both with the proper names. I hope. |
I agree to separate puput from the rest. Nice and neat. Can we delete the previous abstract |
D'oh. I forgot that bit. Yes we should. |
Let me know if this is okay |
Thank you! I think I'd like to hold off on merging changes until we get the site migrated to its new home. |
Oh sure! |
No description provided.