Skip to content

Conversation

@cshirron
Copy link

In the postinst script, if we hit an error building for one kernel, record the error and continue on to the next kernel. When done, exit with the value of any recorded error. This allows us to do a best-effort build for all installed kernels.

@anbe42
Copy link
Collaborator

anbe42 commented Jun 2, 2025

I like the idea, but there should be a way to toggle this behavior (framework.conf setting, environment variable, ...).
If the script is going to exit with an error, it needs to report a list of kernels where building has failed. Reading the scrollback is not feasible.

The correct synopsis prefix for the commit would be 'common.postinst:', not 'dkms:'

@scaronni
Copy link
Member

scaronni commented Jun 2, 2025

The correct synopsis prefix for the commit would be 'common.postinst:', not 'dkms:'

@anbe42 if you think we should have these guidelines in a CONTRIBUTING.md file or something similar, feel free. Currently we have no guidelines in this regard, I also don't follow this convention.

In the postinst script, if we hit an error building for one kernel,
record the error and continue on to the next kernel. When done, exit
with the value of any recorded error. This allows us to do a best-
effort build for all installed kernels. Allow this feature to be
turned off if this behavior isn't desired.
@cshirron cshirron force-pushed the bugfix/continue-on-error branch from 3fd3608 to 703c538 Compare July 8, 2025 15:45
@cshirron
Copy link
Author

cshirron commented Jul 8, 2025

I have taken your suggestions and made the appropriate changes.

@scaronni scaronni requested a review from anbe42 July 10, 2025 09:51
@scaronni scaronni self-assigned this Aug 8, 2025
@scaronni
Copy link
Member

scaronni commented Aug 8, 2025

@cshirron sorry for the delay. Can you please make the necessary adjustments so that the pipelines pass? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants