Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infer scope only on parameters with pointers #15116

Merged
merged 1 commit into from
Apr 19, 2023

Conversation

dkorpel
Copy link
Contributor

@dkorpel dkorpel commented Apr 18, 2023

Trying to fix dlang/ddox#239

@dkorpel dkorpel added the dip1000 memory safety with scope, ref, return label Apr 18, 2023
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @dkorpel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#15116"

@dkorpel dkorpel marked this pull request as ready for review April 18, 2023 18:07
@dkorpel
Copy link
Contributor Author

dkorpel commented Apr 18, 2023

Buildkite is green now, great!

@PetarKirov
Copy link
Member

PetarKirov commented Apr 19, 2023

Can you add a tests for this? Perhaps one that checks this on the language level with static assert and one that checks this in the JSON output (that ddox consumes).

@RazvanN7 RazvanN7 merged commit f84f9c9 into dlang:master Apr 19, 2023
@RazvanN7
Copy link
Contributor

I merged this to unblock buldkite. The tests can be added in a subsequent PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dip1000 memory safety with scope, ref, return
Projects
None yet
Development

Successfully merging this pull request may close these issues.

buildkite test failure
4 participants