fix(lint): Apply De Morgan's law to character validation#325
Open
buggtb wants to merge 2 commits intodlorenc:mainfrom
Open
fix(lint): Apply De Morgan's law to character validation#325buggtb wants to merge 2 commits intodlorenc:mainfrom
buggtb wants to merge 2 commits intodlorenc:mainfrom
Conversation
Replace random adjective-animal names with descriptive task-based names. Workers are now named like 'fix-session-id' instead of 'calm-owl'. Implementation: - Extract 3-4 keywords from task description (filter stop words) - Sanitize to lowercase-hyphenated format - Handle uniqueness with numeric suffixes (-2, -3, etc.) - Fallback to random names if extraction fails - Preserve --name flag for manual override Changes: - Add names.FromTask() for task-based name generation - Add names.EnsureUnique() for uniqueness handling - Update createWorker() to use new naming by default - Add comprehensive tests (20+ test cases) - Add WORKER_NAMING_SPEC.md specification - Add WORKER_NAMING_EXAMPLES.md usage guide Benefits: - Immediate clarity on worker purpose from name - Self-documenting git branches (work/fix-session-id) - Easier debugging and monitoring in logs/tmux - Better PR identification from branch names Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Staticcheck QF1001 suggests rewriting negated compound conditions using De Morgan's law for clarity. Transform: !((r >= 'a' && r <= 'z') || (r >= '0' && r <= '9') || r == '-') to: (r < 'a' || r > 'z') && (r < '0' || r > '9') && r != '-' Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Author
Scope Mismatch DetectedThis PR's contents don't match its stated purpose:
The PR contains two commits:
Additionally, this appears to duplicate PR #323 which has the correct title for this feature. Please review and either:
/cc @buggtb |
Contributor
|
Merge Queue Status: Blocked on workflow approval needed for fork PR. A maintainer needs to approve the workflow run before CI can run. |
Contributor
|
Needs human input: This is a fork PR blocked on maintainer workflow approval (no CI can run). Additionally, there's a scope mismatch — the title says 'lint fix' but the diff is ~742 lines, suggesting a much larger feature change. Needs maintainer review of scope before proceeding. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The condition:
is rewritten as:
Test plan
go test ./internal/names/...passes🤖 Generated with Claude Code