Skip to content

Commit

Permalink
Merge branch 'live' into feature/#380
Browse files Browse the repository at this point in the history
  • Loading branch information
FDelporte committed Nov 20, 2024
2 parents db2db34 + 66d3777 commit c918394
Show file tree
Hide file tree
Showing 7 changed files with 306 additions and 1,473 deletions.
824 changes: 228 additions & 596 deletions src/main/java/com/dlsc/jfxcentral/data/DataRepository.java

Large diffs are not rendered by default.

796 changes: 0 additions & 796 deletions src/main/java/com/dlsc/jfxcentral/data/DataRepository2.java

This file was deleted.

4 changes: 2 additions & 2 deletions src/main/java/com/dlsc/jfxcentral/data/ImageManager.java
Original file line number Diff line number Diff line change
Expand Up @@ -321,7 +321,7 @@ private ObjectProperty<Image> remoteImageProperty(String imageUrl, String append

connection.connect();

Image image = new Image(url.toExternalForm(), !DataRepository.testing);
Image image = new Image(url.toExternalForm(), !DataRepository.isTesting());
image.progressProperty().addListener(it -> {
// exception = 404 -> no image found for given URL
if (image.getProgress() == 1 && image.getException() == null) {
Expand All @@ -332,7 +332,7 @@ private ObjectProperty<Image> remoteImageProperty(String imageUrl, String append
image.exceptionProperty().addListener(it -> image.getException().printStackTrace());

// when running unit tests we set the loaded image immediately
if (DataRepository.testing) {
if (DataRepository.isTesting()) {
property.set(image);
}
} catch (Exception e) {
Expand Down
4 changes: 2 additions & 2 deletions src/main/java/com/dlsc/jfxcentral/data/RSSManager.java
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ public class RSSManager {
private static final Logger LOG = Logger.getLogger(RSSManager.class.getName());

public static String createRSS() {
DataRepository2 repository = DataRepository2.getInstance();
DataRepository repository = DataRepository.getInstance();
List<LinksOfTheWeek> links = repository.getLinksOfTheWeek();

// Based on the example provided on
Expand Down Expand Up @@ -62,7 +62,7 @@ public static String createRSS() {
return "";
}

private static String getLinksOfTheWeekAsHtml(DataRepository2 repository, LinksOfTheWeek linksOfTheWeek) {
private static String getLinksOfTheWeekAsHtml(DataRepository repository, LinksOfTheWeek linksOfTheWeek) {
StringProperty markdownContent = new SimpleStringProperty();
repository.loadLinksOfTheWeekText(linksOfTheWeek, markdownContent);

Expand Down
Loading

0 comments on commit c918394

Please sign in to comment.