-
Notifications
You must be signed in to change notification settings - Fork 393
Starrocks #2518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Starrocks #2518
Conversation
✅ Deploy Preview for dlt-hub-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
@phaethon thanks for this! code looks pretty good, I assume you run it in productions somewhere? I have a few questions
|
|
…errors on Starrocks
|
@phaethon we went through several discussion if we can take this destination into our core and we decided we do not have resources to do that. first we'd need to enable it for all the standard tests which is pretty big amount of work and then we'll need to maintain those tests and run it with every PR. what we surely can do is to add your repo to our docs along other destinations and provide instructions how to use it. it would be clearly marked as community provided and we OFC can attribute you. lmk. if you want to do that. |
|
Yes, I would like this to be linked from official docs if you see it as best way to provide for potential users. I don't have any commercial interest in this, but sooner or later there might be someone else with whom to share maintenance. This raises a couple of practical questions from user perspective. Do I understand correctly that you would recommend installing fork from my repo instead of official dlt package? To install using pip user would need to point to github repo or would it make sense to have a package dlt-starrocks or similar? To create and update documentation I would need to do PR for official repo? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i like it! @rudolfix Please make it happen!
|
I want to participate and work through this PR. @rudolfix Please show me the point to start with. |
|
@Gunnnn if you have ideas for contribution or Starrocks specific issues, you can add them to fork https://github.com/phaethon/dlt (starrocks branch) If there will be traction on the fork repo, it will be more likely to get integrated in main repo with time. And feel free to ask questions how to use it, based on which we can create first documentation pieces |
|
hey @phaethon ! we do a cleanup of all community destinations that we are not merging in the core library. they'll get a docs page where we link to your repo. the proposal for the page is here: pls tell me
we'll close this PR soon |
|
Yes, please, do this link. I have no immediate comments for the proposed text. I suppose I can do a PR at a later stage, too, and if it is just a text update, it shouldn't be hard for anyone involved. |
Description
This is initial implementation of Starrocks support as a separate destination. It implements Stream Load and INSERT INTO SELECT FROM FILES (if S3 compatible staging is used) methods.