Skip to content

Conversation

@lokst
Copy link
Contributor

@lokst lokst commented Oct 6, 2025

This updates our workflows to dispatch Release from the CI workflow.

A similar change was done for the dnsimple-java repository: dnsimple/dnsimple-java#218

Currently the Release workflow is directly triggered upon a tag push but as discussed here, it relies on a third-party action to validate that the CI workflow ran successfully for the tagged commit.

With the changes in this PR, we will use workflow_run to make the Release workflow run automatically when the CI workflow completes, with the following necessary accompanying changes:

  • Trigger the CI workflow upon a tag push that matches a valid pattern
  • We introduce a validate-tag job to the Release workflow, that validates that the CI workflow was triggered from a push of a valid tag, and only allows the publish job to run if the validation succeeds. This is necessary because the CI workflow can be triggered by other conditions including a push to main branch.

Belongs to https://github.com/dnsimple/dnsimple-engineering/issues/361

@lokst lokst self-assigned this Oct 6, 2025
@lokst lokst marked this pull request as ready for review October 6, 2025 03:11
@lokst lokst requested a review from jacegu October 6, 2025 03:21
@lokst lokst merged commit 1c0e38a into main Oct 7, 2025
3 checks passed
@lokst lokst deleted the dispatch-release-workflow-from-ci-workflow branch October 7, 2025 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants