Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new ResolverJWKSet #70

Merged
merged 3 commits into from
Feb 5, 2025
Merged

Use new ResolverJWKSet #70

merged 3 commits into from
Feb 5, 2025

Conversation

jschlyter
Copy link
Member

@jschlyter jschlyter commented Feb 3, 2025

Summary by CodeRabbit

  • Refactor

    • Revamped the internal key management and signature verification process for more integrated handling.
  • Chores

    • Removed outdated key handling components.
    • Upgraded an external dependency and updated the project version for improved compatibility.

@jschlyter jschlyter requested a review from a team as a code owner February 3, 2025 12:44
Copy link

coderabbitai bot commented Feb 3, 2025

Warning

Rate limit exceeded

@jschlyter has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 9 minutes and 23 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 1444fe3 and 7d1edc5.

⛔ Files ignored due to path filters (1)
  • poetry.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • evrec/server.py (3 hunks)

Walkthrough

The pull request removes the evrec/keys.py file that defined the EvrecJWKSet class for handling JSON Web Keys. In evrec/server.py, the key management has been updated to use ResolverJWKSet for client key handling and JWS verification, shifting the logic from an external function to a method of the keyset. Additionally, the project version has been incremented in pyproject.toml and the dnstapir dependency has been updated.

Changes

File(s) Change Summary
evrec/keys.py, evrec/server.py Removed EvrecJWKSet from evrec/keys.py. In evrec/server.py, replaced initialization of self.clients_keyset with ResolverJWKSet and updated the JWS verification call to use the keyset's method.
pyproject.toml Updated project version from 1.1.0.dev3 to 1.1.0.dev4 and revised the dnstapir dependency from version v1.3.2 to v1.4.0.

Sequence Diagram(s)

sequenceDiagram
    participant C as Client
    participant S as EvrecServer
    participant K as ResolverJWKSet
    C->>S: Send request with JWS
    S->>K: verify_jws(jws)
    K-->>S: Return verification result (JWK)
    S->>C: Respond with outcome
Loading

Poem

I'm a rabbit, hopping with delight,
Old keys are gone—a new method in sight.
Resolver's on duty, verifying with cheer,
Version bumped, making our pathway clear.
A joyful code dance, in bytes I skip and prance! 🐇


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@jschlyter
Copy link
Member Author

@coderabbitai review

Copy link

coderabbitai bot commented Feb 5, 2025

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@jschlyter
Copy link
Member Author

@coderabbitai fullreview

Copy link

coderabbitai bot commented Feb 5, 2025

@jschlyter I'll perform a complete review of all changes in this PR.

✅ Actions performed

Full review triggered.

@jschlyter jschlyter merged commit e7e4f8d into main Feb 5, 2025
5 checks passed
@jschlyter jschlyter deleted the use_resolver_jwkset branch February 5, 2025 14:03
@jschlyter jschlyter restored the use_resolver_jwkset branch February 12, 2025 14:38
@coderabbitai coderabbitai bot mentioned this pull request Feb 12, 2025
@jschlyter jschlyter deleted the use_resolver_jwkset branch February 12, 2025 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant