This repository was archived by the owner on Nov 27, 2023. It is now read-only.
Fallback to user-provided cluster from metadata #2269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 8, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1084, #2086, docker-archive-public/docker.compose-ecs#19, docker-archive-public/docker.compose-ecs#20
I'm aware that in light of the impending EOL per #2258, that this contribution will very likely not be accepted, however, I'm still opening this PR here in order to close the loop on #1084 and #2086 in this repository, and will then be opening a matching PR over in https://github.com/docker/compose-ecs to support docker-archive-public/docker.compose-ecs#7.