Skip to content

fix: typo on version name#2536

Merged
tianon merged 1 commit intodocker-library:masterfrom
zisuu:patch-1
Feb 4, 2025
Merged

fix: typo on version name#2536
tianon merged 1 commit intodocker-library:masterfrom
zisuu:patch-1

Conversation

@zisuu
Copy link
Copy Markdown
Contributor

@zisuu zisuu commented Feb 4, 2025

The examples are showing JDK version 21 but the description text above states JDK version 11

the example below shows Java version 21, not version 11
@tianon
Copy link
Copy Markdown
Member

tianon commented Feb 4, 2025

(per the failing CI, I've dropped the commit touching README.md as it's auto-generated)

@zisuu
Copy link
Copy Markdown
Contributor Author

zisuu commented Feb 4, 2025

(per the failing CI, I've dropped the commit touching README.md as it's auto-generated)

thanks, sorry was not aware of that

Copy link
Copy Markdown
Member

@tianon tianon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

(FYI @gdams @sxa - I'm merging because it looks correct to me 👍)

@tianon tianon merged commit 936993f into docker-library:master Feb 4, 2025
6 checks passed
@gdams
Copy link
Copy Markdown
Contributor

gdams commented Feb 4, 2025

I’m actually not sure about this change. Admittedly the wording isn’t great but what we’re trying to say is that jlink is supported on OpenJDK 11 and newer.

@tianon
Copy link
Copy Markdown
Member

tianon commented Feb 4, 2025

Oh, good point, sorry! We can revert if you want, or maybe you have some new wording you'd like to add?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants