Save full list of entries for every source #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(I dedicate this change to @mrjoelkamp 🫡 😭 ❤️) |
When we normalize sources by deduplicating on `sourceId`, we end up losing a little bit of data that's important for being able to reconnect `source` objects with their lines in `library/foo`. This resolves that by adjusting our `entry` object to be a vector of `entries` instead, but sorted using the same `SOURCE_DATE_EPOCH` tiebreaker we used previously so that `.entries[0]` is the same as our old `.entry`, but we keep the full list of values for later use/lookup/cross-referencing. I have additionally verified that `meta.jq` here was the only place we are actively consuming from the `.entry` object (currently), so this should be fully sufficient (no changes necessary elsewhere).
|
An (easy) alternative we could do would be to calculate this |
|
(but that makes using it for the intended purpose more annoying because the data is in two places, so I think this change is probably more correct/useful as-is and the one-time heavy indentation change is worth it) |
yosifkit
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we normalize sources by deduplicating on
sourceId, we end up losing a little bit of data that's important for being able to reconnectsourceobjects with their lines inlibrary/foo.This resolves that by adjusting our
entryobject to be a vector ofentriesinstead, but sorted using the sameSOURCE_DATE_EPOCHtiebreaker we used previously so that.entries[0]is the same as our old.entry, but we keep the full list of values for later use/lookup/cross-referencing.I have additionally verified that
meta.jqhere was the only place we are actively consuming from the.entryobject (currently), so this should be fully sufficient (no changes necessary elsewhere).