-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speed up sources.sh even more #118
Conversation
sources.sh
Outdated
value: { | ||
($e.arches | keys[]): [$e.sourceId] | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
value: { | |
($e.arches | keys[]): [$e.sourceId] | |
} | |
value: { ($e.arches | keys[]): [$e.sourceId] }, |
sources.sh
Outdated
| ( $s.arches[] | .tags[], .archTags[] ) | ||
| { | ||
key: ., | ||
value: { ($s.arches | keys[]): [$s.sourceId] } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
value: { ($s.arches | keys[]): [$s.sourceId] } | |
value: { ($s.arches | keys[]): [$s.sourceId] }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should also add a comment that this happens pre-arches-merge so looping over arches twice is fine?
by improving slow jq section in sources.sh
by improving slow
jq
section in sources.sh (building upon the gains from #115)Local speed improvement:
After tianon's improvements and a reorder 😍
And on a Jenkins worker versus the ~7 minutes in #115 (pre-feedback changes): 🎉 🎊 🥳