Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor: docker/docker 2b1097f08088 (removes containerd dependency) #5252

Merged
merged 5 commits into from
Jul 26, 2024

Conversation

thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Jul 16, 2024


vendor: golang.org/x/sys v0.22.0

full diff: golang/sys@v0.21.0...v0.22.0

vendor: github.com/moby/sys/signal v0.7.1

full diff: moby/sys@signal/v0.7.0...signal/v0.7.1

vendor: github.com/moby/sys/symlink v0.3.0

full diff: moby/sys@symlink/v0.2.0...symlink/v0.3.0

vendor: github.com/moby/sys/sequential v0.6.0

full diff: moby/sys@sequential/v0.5.0...sequential/v0.6.0

vendor: docker/docker 2b1097f08088 (removes containerd dependency)

full diff: moby/moby@aae0440...2b1097f

The userns package in libcontainer was integrated into the moby/sys/user
module at commit 3778ae603c706494fd1e2c2faf83b406e38d687d.

The userns package is used in many places, and currently either depends
on runc/libcontainer, or on containerd, both of which have a complex
dependency tree. This patch is part of a series of patches to unify the
implementations, and to migrate toward that implementation to simplify
the dependency tree.

- A picture of a cute animal (not mandatory but encouraged)

@codecov-commenter
Copy link

codecov-commenter commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.46%. Comparing base (826fc32) to head (f0a29af).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5252   +/-   ##
=======================================
  Coverage   61.45%   61.46%           
=======================================
  Files         299      299           
  Lines       20856    20856           
=======================================
+ Hits        12818    12820    +2     
+ Misses       7122     7120    -2     
  Partials      916      916           

@thaJeztah thaJeztah changed the title update docker/docker to remove containerd dependency vendor: docker/docker 2b1097f08088 (removes containerd dependency) Jul 25, 2024
full diff: moby/moby@aae0440...2b1097f

The userns package in libcontainer was integrated into the moby/sys/user
module at commit 3778ae603c706494fd1e2c2faf83b406e38d687d.

The userns package is used in many places, and currently either depends
on runc/libcontainer, or on containerd, both of which have a complex
dependency tree. This patch is part of a series of patches to unify the
implementations, and to migrate toward that implementation to simplify
the dependency tree.

[3778ae603c706494fd1e2c2faf83b406e38d687d]: opencontainers/runc@3778ae6

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah marked this pull request as ready for review July 25, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants