pkg: add cagent by vvoland · Pull Request #258 · docker/packaging

vvoland · 2025-09-05T22:34:33Z

No description provided.

crazy-max · 2025-09-09T14:28:19Z

+# Returns the list of supported platforms for static packages for a given package.
+function "staticPkgPlatforms" {
+  params = [pkg]
+  result = pkg == "cagent" ? [] : pkgPlatforms(pkg)


Looking at the Dockerfile: https://github.com/docker/cagent/blob/ab6f7b276b29434623daf733a3d0b524d2d6601d/Dockerfile

I think we can make "static" builds, similar to what has be done for credential helpers:

packaging/pkg/credential-helpers/Dockerfile

Lines 158 to 210 in 29ca532

# static

FROM --platform=$BUILDPLATFORM ${DISTRO_IMAGE} AS builder-static-nosdk

COPY --from=xx / /

ARG DEBIAN_FRONTEND

RUN apt-get update && apt-get install -y --no-install-recommends bash ca-certificates file git zip tar \

dpkg-dev clang make pkg-config

ENV GOPROXY="https://proxy.golang.org|direct"

ENV GOPATH="/go"

ENV PATH="$PATH:/usr/local/go/bin:$GOPATH/bin"

ENV GOTOOLCHAIN="local"

ENV GO111MODULE="on"

ENV CGO_ENABLED="1"

ARG PKG_NAME

ARG PKG_REF

ARG NIGHTLY_BUILD

WORKDIR /build

ARG TARGETPLATFORM

RUN xx-apt-get install -y gcc libsecret-1-dev

RUN --mount=type=bind,source=scripts/pkg-static-build.sh,target=/usr/local/bin/pkg-static-build \

--mount=type=bind,from=scripts,source=gen-ver.sh,target=/usr/local/bin/gen-ver \

--mount=type=bind,from=scripts,source=fix-cc.sh,target=/usr/local/bin/fix-cc \

--mount=type=bind,from=src,source=/src,target=/usr/local/src/credential-helpers \

--mount=type=bind,from=gocross,source=/usr/local/go,target=/usr/local/go,rw \

OUTDIR=/out BUILDDIR=/build SRCDIR=/usr/local/src/credential-helpers pkg-static-build

FROM builder-static-nosdk AS builder-static-linux

FROM builder-static-nosdk AS builder-static-windows

FROM --platform=$BUILDPLATFORM ${DISTRO_IMAGE} AS builder-static-darwin

COPY --from=xx / /

ARG DEBIAN_FRONTEND

RUN apt-get update && apt-get install -y --no-install-recommends bash ca-certificates file git zip tar \

dpkg-dev clang make pkg-config

ENV GOPROXY="https://proxy.golang.org|direct"

ENV GOPATH="/go"

ENV PATH="$PATH:/usr/local/go/bin:$GOPATH/bin"

ENV GOTOOLCHAIN="local"

ENV GO111MODULE="on"

ENV CGO_ENABLED="1"

ARG PKG_NAME

ARG PKG_REF

ARG NIGHTLY_BUILD

WORKDIR /build

ARG TARGETPLATFORM

RUN xx-apt-get install -y gcc libsecret-1-dev

RUN --mount=type=bind,source=scripts/pkg-static-build.sh,target=/usr/local/bin/pkg-static-build \

--mount=type=bind,from=scripts,source=gen-ver.sh,target=/usr/local/bin/gen-ver \

--mount=type=bind,from=scripts,source=fix-cc.sh,target=/usr/local/bin/fix-cc \

--mount=type=bind,from=src,source=/src,target=/usr/local/src/credential-helpers \

--mount=type=bind,from=gocross,source=/usr/local/go,target=/usr/local/go,rw \

--mount=type=bind,from=osxcross,src=/osxsdk,target=/xx-sdk \

OUTDIR=/out BUILDDIR=/build SRCDIR=/usr/local/src/credential-helpers pkg-static-build

FROM builder-static-$TARGETOS AS builder-static

Windows static binaries need zig and I haven't figured it out why yet 😅

Also we wouldn't be deploying any static binaries to download.docker.com yet.

My main intent here is to provide cagent packages for Linux distros, so the static binaries are not really needed.

The static binaries are already published in releases https://github.com/docker/cagent/releases, so let's not duplicate that.

Windows static binaries need zig and I haven't figured it out why yet 😅

zig is not needed, you can rely on xx and install gcc cross package (mingw for windows). This should be enough, like we do for credential helpers:

packaging/pkg/credential-helpers/Dockerfile

Line 175 in 29ca532

RUN xx-apt-get install -y gcc libsecret-1-dev

See https://github.com/docker/packaging/actions/runs/17588609365/job/49963306654#step:7:1106

The static binaries are already published in releases https://github.com/docker/cagent/releases, so let's not duplicate that.

Not sure why cagent would be an exception where for other pkgs we create static binaries like Buildx that also have assets on GitHub. That would be great to be consistent across packages imo.

We won't be able to use some of the stuff that the cagent pipeline has like: https://github.com/docker/cagent/blob/ab6f7b276b29434623daf733a3d0b524d2d6601d/Dockerfile#L16-L19

There's also some stuff that depends on Docker Desktop, which should probably be omitted for the Linux distro builds: docker/docker-agent#151

We won't be able to use some of the stuff that the cagent pipeline has like: https://github.com/docker/cagent/blob/ab6f7b276b29434623daf733a3d0b524d2d6601d/Dockerfile#L16-L19

There's also some stuff that depends on Docker Desktop, which should probably be omitted for the Linux distro builds: docker/cagent#151

Ok I see, then currently linux packages are broken anyway looking at your PR docker/docker-agent#151? I guess we wait until your PR is merged so linux pkgs are built with this build tag and we could have static packages as well?

docker/docker-agent#192 should help so we don't need CGO anymore and can do proper static builds

thaJeztah · 2025-10-03T12:40:35Z

@@ -0,0 +1,52 @@
+%global debug_package %{nil}
+
+Name: cagent


I haven't used cagent; does it use the CLI and/or daemon? We could add a "weak" dependency if it does, e.g. as we did for the model CLI (although that's more clearly a CLI plugin);

Enhances: docker-ce-cli

It's not a cli plugin afaik cc @dgageot @rumpl

I haven't used cagent

😱

It's not a cli plugin no

@rumpl does it have any dependency / recommended installation w.r.t. "if you use this, you should also have docker or docker-cli installed? (mostly trying to see if we need to define some relation between the packages, or it it should be considered fully separate from our other offerings)

A recommended would be Docker Desktop actually, for pushing and pulling agents.

thaJeztah · 2025-10-03T14:30:53Z

+Package: cagent
+Priority: optional
+Architecture: linux-any
+Description: TODO


@rumpl you are a developer at Docker with a deep understanding of of cagent and packaging deb and rpm packages. Write a short description to be used as Description for the official cagent RPM and Deb packages. 🍿

My agent tells me this:

Short Description (one-line):

Multi-agent AI runtime for orchestrating specialized AI agents with tools and MCP integration

Long Description:

cagent is a powerful multi-agent AI runtime that enables you to create, configure, and orchestrate specialized AI agents that work together to solve complex problems. Each agent can be equipped with specific tools, knowledge domains, and capabilities. Key features: * Multi-agent architecture with hierarchical task delegation * Declarative YAML-based agent configuration * MCP (Model Context Protocol) integration for extensible tooling * Support for multiple AI providers (OpenAI, Anthropic, Google Gemini, Docker Model Runner) * Built-in reasoning tools (think, todo, memory) for complex problem-solving * Docker Hub integration for sharing and distributing agent configurations * Event-driven streaming architecture for real-time responses cagent makes it easy to build agent teams where specialized agents collaborate, each bringing their own expertise and tools to handle specific aspects of user requests. Perfect for developers building AI-powered workflows and automation.

(but don't forget adding a . for empty lines, which I think is required for debs/rpms 😂 )

packaging/pkg/docker-cli/deb/control

Lines 27 to 32 in 1ff8587

Description: Docker CLI: the open-source application container engine

Docker is a product for you to build, ship and run any application as a

lightweight container

.

Docker containers are both hardware-agnostic and platform-agnostic. This means

they can run anywhere, from your laptop to the largest cloud compute instance and

Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>

Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>

thaJeztah · 2025-10-21T05:26:39Z

Looks like cagent doesn't compile on Windows;

0.286 + go build -trimpath -ldflags '-w -X '\''github.com/docker/cagent/pkg/version.Version=v0.0.0-20251020133613-26330cc'\'' -X '\''github.com/docker/cagent/pkg/version.Commit=26330cc0e1579ab91fd24a3459986256680d8330'\''' -o /build/cagent/cagent.exe .
0.286 /usr/local/src/cagent /build
28.48 # github.com/docker/cagent/pkg/tools/builtin
28.48 pkg/tools/builtin/shell.go:59:4: unknown field Setpgid in struct literal of type syscall.SysProcAttr
28.48 pkg/tools/builtin/shell.go:260:16: undefined: syscall.Kill

thaJeztah · 2025-10-21T05:39:11Z

Looks to be docker/docker-agent@832479e;

Fix: Kill shell-spawned processes when stopping sessions docker-agent#523

I don't think CI on that repo runs on anything other than Linux? Or is it not meant to be run on mac and windows? 🙈😅

crazy-max · 2025-10-21T09:04:08Z

Yes opened docker/docker-agent#562 and seems there is an on-going fix docker/docker-agent#564

crazy-max

PTAL @dgageot @rumpl

vvoland self-assigned this Sep 5, 2025

github-actions Bot added the area/ci label Sep 5, 2025

vvoland force-pushed the add-cagent branch from 438e8a4 to e7c46d6 Compare September 5, 2025 22:37

vvoland marked this pull request as ready for review September 8, 2025 09:42

crazy-max reviewed Sep 9, 2025

View reviewed changes

vvoland mentioned this pull request Sep 10, 2025

Put Docker Desktop integration behind a build tag docker/docker-agent#151

Closed

crazy-max force-pushed the add-cagent branch 5 times, most recently from 3839259 to 8c5450b Compare October 3, 2025 12:24

thaJeztah reviewed Oct 3, 2025

View reviewed changes

crazy-max force-pushed the add-cagent branch from 8c5450b to 317d0cc Compare October 3, 2025 13:24

thaJeztah reviewed Oct 3, 2025

View reviewed changes

crazy-max force-pushed the add-cagent branch from 317d0cc to 4b21b88 Compare October 20, 2025 14:11

crazy-max requested a review from a team as a code owner October 20, 2025 14:11

crazy-max force-pushed the add-cagent branch 2 times, most recently from cd51578 to b30aa54 Compare October 20, 2025 14:20

vvoland and others added 4 commits October 20, 2025 16:33

pkg: add cagent

f99d766

Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>

cagent: static builds

b2019d7

Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>

cagent: BuildTime var removed and align other ldflags

cd73fdb

Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>

cagent: package description

378e305

Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>

crazy-max force-pushed the add-cagent branch from b30aa54 to 378e305 Compare October 23, 2025 13:11

crazy-max approved these changes Oct 24, 2025

View reviewed changes

rumpl approved these changes Oct 24, 2025

View reviewed changes

crazy-max merged commit 8ad5d78 into docker:main Oct 24, 2025
494 checks passed

	# static
	FROM --platform=$BUILDPLATFORM ${DISTRO_IMAGE} AS builder-static-nosdk
	COPY --from=xx / /
	ARG DEBIAN_FRONTEND
	RUN apt-get update && apt-get install -y --no-install-recommends bash ca-certificates file git zip tar \
	dpkg-dev clang make pkg-config
	ENV GOPROXY="https://proxy.golang.org\|direct"
	ENV GOPATH="/go"
	ENV PATH="$PATH:/usr/local/go/bin:$GOPATH/bin"
	ENV GOTOOLCHAIN="local"
	ENV GO111MODULE="on"
	ENV CGO_ENABLED="1"
	ARG PKG_NAME
	ARG PKG_REF
	ARG NIGHTLY_BUILD
	WORKDIR /build
	ARG TARGETPLATFORM
	RUN xx-apt-get install -y gcc libsecret-1-dev
	RUN --mount=type=bind,source=scripts/pkg-static-build.sh,target=/usr/local/bin/pkg-static-build \
	--mount=type=bind,from=scripts,source=gen-ver.sh,target=/usr/local/bin/gen-ver \
	--mount=type=bind,from=scripts,source=fix-cc.sh,target=/usr/local/bin/fix-cc \
	--mount=type=bind,from=src,source=/src,target=/usr/local/src/credential-helpers \
	--mount=type=bind,from=gocross,source=/usr/local/go,target=/usr/local/go,rw \
	OUTDIR=/out BUILDDIR=/build SRCDIR=/usr/local/src/credential-helpers pkg-static-build
	FROM builder-static-nosdk AS builder-static-linux
	FROM builder-static-nosdk AS builder-static-windows

	FROM --platform=$BUILDPLATFORM ${DISTRO_IMAGE} AS builder-static-darwin
	COPY --from=xx / /
	ARG DEBIAN_FRONTEND
	RUN apt-get update && apt-get install -y --no-install-recommends bash ca-certificates file git zip tar \
	dpkg-dev clang make pkg-config
	ENV GOPROXY="https://proxy.golang.org\|direct"
	ENV GOPATH="/go"
	ENV PATH="$PATH:/usr/local/go/bin:$GOPATH/bin"
	ENV GOTOOLCHAIN="local"
	ENV GO111MODULE="on"
	ENV CGO_ENABLED="1"
	ARG PKG_NAME
	ARG PKG_REF
	ARG NIGHTLY_BUILD
	WORKDIR /build
	ARG TARGETPLATFORM
	RUN xx-apt-get install -y gcc libsecret-1-dev
	RUN --mount=type=bind,source=scripts/pkg-static-build.sh,target=/usr/local/bin/pkg-static-build \
	--mount=type=bind,from=scripts,source=gen-ver.sh,target=/usr/local/bin/gen-ver \
	--mount=type=bind,from=scripts,source=fix-cc.sh,target=/usr/local/bin/fix-cc \
	--mount=type=bind,from=src,source=/src,target=/usr/local/src/credential-helpers \
	--mount=type=bind,from=gocross,source=/usr/local/go,target=/usr/local/go,rw \
	--mount=type=bind,from=osxcross,src=/osxsdk,target=/xx-sdk \
	OUTDIR=/out BUILDDIR=/build SRCDIR=/usr/local/src/credential-helpers pkg-static-build

	FROM builder-static-$TARGETOS AS builder-static

	Description: Docker CLI: the open-source application container engine
	Docker is a product for you to build, ship and run any application as a
	lightweight container
	.
	Docker containers are both hardware-agnostic and platform-agnostic. This means
	they can run anywhere, from your laptop to the largest cloud compute instance and

Uh oh!

Conversation

vvoland commented Sep 5, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

thaJeztah Oct 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Short Description (one-line):

Long Description:

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

thaJeztah commented Oct 21, 2025

Uh oh!

thaJeztah commented Oct 21, 2025

Uh oh!

crazy-max commented Oct 21, 2025

Uh oh!

crazy-max left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

thaJeztah Oct 3, 2025 •

edited

Loading