Skip to content

static: add checksum files for package archives - #495

Merged
vvoland merged 2 commits into
docker:mainfrom
crazy-max:static-checksums
Aug 19, 2026
Merged

static: add checksum files for package archives#495
vvoland merged 2 commits into
docker:mainfrom
crazy-max:static-checksums

Conversation

@crazy-max

@crazy-max crazy-max commented Aug 15, 2026

Copy link
Copy Markdown
Member

needs #493
follow-up #493 (comment)

Static package builds now emit a sibling .sha256 file for each generated .tgz and .zip archive. Static package verification checks the generated checksum before unpacking artifacts.

Comment thread pkg/agent/verify.Dockerfile Outdated
set -x
cd "${package%/*}"
sha256sum -c "${package##*/}.sha256"
tar zxvf $package -C /usr/bin --strip-components=1

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one (and all the similar Dockerfiles) need the same ##/* treatment in the tar invocation, right? (since you added cd)

@tianon

tianon commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Is all the duplication expected? This is quite a large PR for what it does 😅

Static package builds now emit a sibling .sha256 file for each generated .tgz and .zip archive.

Static package verification checks the generated checksum before unpacking artifacts.

Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
@crazy-max

crazy-max commented Aug 19, 2026

Copy link
Copy Markdown
Member Author

Is all the duplication expected? This is quite a large PR for what it does 😅

Yeah it's duplicated in multiple places, will look at improving this as follow-up. Made a simple share checksum file generation script for now.

Static package builds now use a shared helper to write archive checksum files instead of repeating the same sha256sum block in every package script.

Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
@crazy-max
crazy-max requested a review from vvoland August 19, 2026 13:51
@crazy-max
crazy-max marked this pull request as ready for review August 19, 2026 13:52
@crazy-max
crazy-max requested review from a team as code owners August 19, 2026 13:52
@crazy-max
crazy-max requested review from glours and ndeloof and removed request for a team August 19, 2026 13:52
@vvoland
vvoland merged commit 123a896 into docker:main Aug 19, 2026
1429 checks passed
@crazy-max
crazy-max deleted the static-checksums branch August 19, 2026 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants