Add sbx-cli mixin: installs the sbx CLI inside a sandbox - #180
Open
alakae wants to merge 1 commit into
Open
Conversation
For validating/inspecting kit specs from within a sandbox, mainly useful for kits outside sbx-kits-contrib's own TCK tooling. Tracks the latest docker/sbx-releases build rather than pinning a version. Signed-off-by: Alain Kaeslin <ak@alainkaeslin.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Installs the
sbxCLI inside a sandbox, mainly forsbx kit validate/sbx kit inspecton kitspecs that don't live in this repo's own TCK tooling. Tracks the latest
docker/sbx-releasesbuild rather than pinning a version.
Spec choices worth flagging for review
recommended verification mechanism here, if any?
latestinstead of pinning a version, sincesbxis the product this repotargets and a stale pinned build would drift from what users actually run.
Origin
New kit, written for this PR.
Test plan
CI runs
kit validateand the TCK on every PR. CI does not run e2e onfork PRs (Docker Hub secrets aren't exposed there), so the e2e step below is
required from your side before requesting review.
sbx kit validate ./sbx-cli/passes./scripts/test-kit.sh sbx-clipasses (the TCK)./scripts/test-kit-e2e.sh sbx-clipasses. The script applies the samedeny-allbaseline CI uses and scopes everything to its own daemon(
--app-name sbx-kits-contrib-tck), so my main sbx state is untouched.Every entry I added to
network.allowedDomainscame fromsbx --app-name sbx-kits-contrib-tck policy log <tck-e2e-…>, not a guess.sbx run shell --kit . --name sbx-cli-smoke .and verifiedsbx versionruns inside the container:One-time setup if you haven't run e2e on this machine before:
sbx --app-name sbx-kits-contrib-tck login.See CONTRIBUTING.md → Verifying locally
and README → Declare every domain your kit needs
for the cross-arch domain gotchas (
archive.ubuntu.com,security.ubuntu.com,ports.ubuntu.com) and the package-manager refresh trap.