Add axe kit - #245
Open
kristiyan-velkov wants to merge 1 commit into
Open
Conversation
Ship WCAG audits without @axe-core/cli's unpinned chromedriver@latest dependency. Signed-off-by: kristiyan.velkov <christiyanweb@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
axemixin that runs Deque axe-core 4.13.0 against a URL and prints the JSON report (exit 1 if there are violations).playwright/lighthousekits (/opt/ms-playwright+CHROME_PATH=/usr/local/bin/chromium).Spec choices worth flagging for review
@axe-core/cli. That package depends onchromedriver@latest(unpinned postinstall download) and Selenium, which will not match Playwright Chromium. The kit installs@axe-core/playwright@4.13.0+playwright@1.61.1and ships a thinaxe <url> [--save file.json]wrapper underfiles/home/.local/bin/axe./opt/ms-playwrightalready has achromebinary (compose withplaywrightorlighthouse).Origin
New frontend-tool mixin, patterned on
lighthouse/andplaywright/.Test plan
./scripts/test-kit.sh axepasses (the TCK)./scripts/test-kit-e2e.sh axepasses under deny-allsbx run --kit ./axe/ claudethenaxe http://localhost:3000against a local pageMade with Cursor