Pushing docknetwork libraries to latest version 0.25 #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lanterno
force-pushed
the
update-crypto-lib-to-version-0-25
branch
2 times, most recently
from
6423bb2 to
1446a0a
Compare
Also adds node v22 and removes v21 from the CI build matrix
This update aligns with API changes in the underlying crypto library (version 0.25) that now requires explicit specification of hash functions for improved type safety and flexibility.
lanterno
force-pushed
the
update-crypto-lib-to-version-0-25
branch
from
1446a0a to
816a03b
Compare
Contributor
Author
|
Hi @lovesh, last PR to update this repo to the last dependency versions from the I'm working on testing |
Contributor
Author
|
@lovesh Update: Just finished testing the crypto-wasm-ts library after these updates, and all tests succeed with no changes needed. |
lanterno
commented
Nov 5, 2025
| strategy: | ||
| matrix: | ||
| node-version: [22.x, 24.x] | ||
| node-version: [22.x, 24.x, 25.x] |
Contributor
Author
There was a problem hiding this comment.
it was only testing against the two last TLS versions. We should also test against the last version, and update it regularly. I think 22.x could be dropped as well, but I left this out for now.
lanterno
commented
Nov 5, 2025
Comment on lines
+18
to
+21
| - uses: actions/checkout@v5 | ||
| - name: Install WASM-Pack | ||
| run: curl https://rustwasm.github.io/wasm-pack/installer/init.sh -sSf | sh | ||
| - uses: actions/setup-node@v4 | ||
| - uses: actions/setup-node@v6 |
Contributor
Author
There was a problem hiding this comment.
Not necessary for this PR, but it's always nice to clean up when given the chance.
lovesh
approved these changes
Nov 7, 2025
Collaborator
|
@lanterno Thank you for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With the merge of the last two PRs #17, and #19 the project is now ready to run with Rust 1.89 (latest stable version as of the time of writing).
In the PR, I update Rust version, and also update all the WASM libraries to the latest versions.
Notice the change in the script file
scripts/build-package.shwhere this change arises from a very subtle change in the workings of the librarywasm-bindgen.This encourages a rethink on this part of the build script to avoid future bugs.
Next steps
Update the crypto-wasm-ts library
PR checklist
yarn install; yarn build; yarn testto make sure everything runs as before.Does this PR introduce a breaking change?
Which merge strategy will you use?