fix(pptx): process slide shapes in visual reading order#3393
Open
Adityav20 wants to merge 4 commits into
Open
Conversation
Contributor
|
✅ DCO Check Passed Thanks @Adityav20, all your commits are properly signed off. 🎉 |
Contributor
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
I, rifi9351 <aditya.vikram@uni-weimar.de>, hereby add my Signed-off-by to this commit: bc09fca Signed-off-by: rifi9351 <aditya.vikram@uni-weimar.de>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Signed-off-by: rifi9351 <aditya.vikram@uni-weimar.de>
Signed-off-by: rifi9351 <aditya.vikram@uni-weimar.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR improves PPTX parsing by processing slide shapes in visual reading order instead of PowerPoint’s internal creation/z-order.
Previously, when a slide had multiple subheadings with separate bullet text boxes, bullet points could be grouped under the wrong subheading if the PPTX shape order did not match the visible slide layout.
The PPTX backend now sorts shapes top-to-bottom and left-to-right, with a small row tolerance for near-aligned objects. This keeps visually related subheadings and bullet lists together during extraction.
A regression test was added for a slide where the second bullet textbox is stored before its subheading internally, but appears below it visually.
Issue resolved by this Pull Request:
Resolves #1324
Checklist: