-
Notifications
You must be signed in to change notification settings - Fork 1
feat(helm): init helm chart #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
TartanLeGrand
wants to merge
27
commits into
docmost:main
Choose a base branch
from
TartanLeGrand:feat/init-chart
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rom for SMTP settings
… in deployment.yaml
…n deployment configuration
…s and default to local storage
…lassName based on existing settings
…d local storage handling
…r and data source settings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a Helm chart for deploying Docmost, transitioning the Kubernetes deployment from static YAML manifests to a configurable, templated Helm-based approach. The new chart includes templates for all major Kubernetes resources, supports optional integrations (Redis, PostgreSQL), and provides automated testing and linting via GitHub Actions. The previous monolithic
app.yamlmanifest is removed in favor of this modular, maintainable solution.Helm Chart Introduction and Resource Templating:
Added a new Helm chart in
charts/docmost/, including templates forDeployment,Service,Ingress,HTTPRoute,ServiceAccount,Secret, and autoscaling (hpa.yaml). These templates use values fromvalues.yamlfor flexible configuration. (charts/docmost/templates/deployment.yaml,charts/docmost/templates/service.yaml,charts/docmost/templates/ingress.yaml,charts/docmost/templates/httproute.yaml,charts/docmost/templates/serviceaccount.yaml,charts/docmost/templates/secret.yaml,charts/docmost/templates/hpa.yaml) [1] [2] [3] [4] [5] [6] [7]Defined chart metadata, dependencies (Redis, PostgreSQL), and versioning in
Chart.yaml, enabling optional database and cache integration via subcharts. (charts/docmost/Chart.yaml)DevOps and Testing Enhancements:
Added a GitHub Actions workflow (
test-lint.yml) to automate Helm chart linting, dependency setup, and installation tests on pull requests. This ensures chart integrity and deployment reliability. (.github/workflows/test-lint.yml)Included a Helm test manifest (
test-connection.yaml) to verify service connectivity post-deployment. (charts/docmost/templates/tests/test-connection.yaml)Documentation and Chart Usability:
Added a comprehensive
NOTES.txttemplate to guide users on accessing the deployed application based on their chosen ingress method (HTTPRoute, Ingress, NodePort, LoadBalancer, ClusterIP). (charts/docmost/templates/NOTES.txt)Provided a
.helmignorefile to exclude unnecessary files from chart packaging. (charts/docmost/.helmignore)Removal of Previous Static Manifests:
app.yamlKubernetes manifest, fully replacing it with Helm chart templates for improved maintainability and flexibility. (app.yaml)