Skip to content

Add a more helpful error message when unkown options are encountered #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add a more helpful error message when unkown options are encountered #65

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion docopt.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,15 @@ func parse(doc string, argv []string, help bool, version string, optionsFirst bo
return
}

err = newUserError("")
if len(*left) > 0 {
var left_names []string
for _, l := range(*left) {
left_names = append(left_names, l.name)
}
err = newUserError(fmt.Sprintf("Unknown option(s): %s", strings.Join(left_names, ", ")))
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@caldwell - I believe golint will complain about this error message because the first letter is capitalized.
https://github.com/golang/go/wiki/CodeReviewComments#error-strings

} else {
err = newUserError("")
}
output = handleError(err, usage)
return
}
Expand Down