Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow removing deprecated from billeo-engine #12

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

Nao-ris
Copy link
Contributor

@Nao-ris Nao-ris commented Sep 13, 2024

The function default_collection_or_error is useful for database calls in transactions.

Remove the deprecated flag inside structs that are still needed, else the deprecated warning is triggered even if the value is None.

@Nao-ris Nao-ris requested a review from a team as a code owner September 13, 2024 09:12
@Nao-ris Nao-ris merged commit 4fb1968 into main Sep 13, 2024
3 of 4 checks passed
@Nao-ris Nao-ris deleted the remove_deprecated_from_engine branch September 13, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants