Rework creation of autoincrement objects on Oracle #6810
+116
−95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reworks the code that auto-generates the names of the Oracle objects that implement the auto-increment behavior (the primary key constraint, the trigger and the sequence). It pursuits two goals:
Schema\Identifierclass, which is deprecated and has to be eventually removed.PrimaryKeyConstraint, which is to be introduced later.P.S. I just realized that we don't really have to create a PK as part of setting up auto-increment. For instance, MySQL requires an auto-increment column to be part of the PK, so we can expect the user to explicitly created the PK on Oracle as well. But even if we make this change, the work in this PR won't be thrown away, it will still be relevant for the sequence and the trigger.