Make BaseDateTypeTestCase generic #7268
Open
+11
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
approved these changes
Jan 2, 2026
Member
The changes themselves are fine, but I don't understand where the improvement is. The changes in the types do not eliminate any false positive errors as one might expect. |
Member
|
I guess that's because we don't use phpstan level 9 yet? |
Member
In this case, I'd expect this change to be part of a PR that bumps PHPStan to level 9. Otherwise, this improvement can be accidentally broken unnoticed. |
morozov
approved these changes
Jan 2, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves the static analysis of the
BaseDateTypeTestCaseclass by making the analyzer aware of the actualTypesubclass that we test against.