Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some generics to tests #2391

Merged
merged 1 commit into from
Nov 22, 2021
Merged

Add some generics to tests #2391

merged 1 commit into from
Nov 22, 2021

Conversation

franmomu
Copy link
Contributor

@franmomu franmomu commented Nov 17, 2021 •
edited
Loading

Q A
Type improvement
BC Break no
Fixed issues

Summary

This is made on top of #2385

This PR fixes some of the issues (the easiest one I think) that appear when adding checkGenericClassInNonGenericObjectType, it goes from 198 issues to 104

@franmomu franmomu added the Task label Nov 17, 2021
@franmomu franmomu added this to the 2.3.0 milestone Nov 17, 2021
@malarzm
Copy link
Member

malarzm commented Nov 18, 2021

I've merged #2385 but this must be from before rebase there 😅 @franmomu mind rebasing this one?

@franmomu
Copy link
Contributor Author

I've merged #2385 but this must be from before rebase there 😅 @franmomu mind rebasing this one?

yeah, sure, no problem!

@malarzm malarzm merged commit 127da81 into doctrine:2.3.x Nov 22, 2021
@malarzm
Copy link
Member

malarzm commented Nov 22, 2021

Thanks @franmomu!

@franmomu franmomu deleted the generics_1 branch November 23, 2021 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malarzm malarzm malarzm approved these changes

Assignees
No one assigned
Labels
Task
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@franmomu @malarzm