[3.x] Make Types strongly typed #2945
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This pull request adds strong typing to the Types namespace and updates PHPBench benchmarks to use PHP attributes instead of annotations. The changes improve type safety across type conversion methods and modernize the benchmark infrastructure.
Key Changes:
- Added
mixedparameter types and specific return types to type conversion methods across all Type classes - Typed class constants as
stringin Type class and BaseBench - Migrated PHPBench benchmarks from annotation-based to attribute-based configuration
- Added
Stringableinterface implementation to the baseTypeclass
Reviewed changes
Copilot reviewed 30 out of 30 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Types/Type.php | Added Stringable interface, typed constants, and added method parameter/return types |
| src/Types/Versionable.php | Added mixed parameter and return types to interface method |
| src/Types/Incrementable.php | Added mixed parameter and return types to interface method |
| src/Types/StringType.php | Added parameter and return types to conversion methods |
| src/Types/TimestampType.php | Added parameter and return types with proper union types |
| src/Types/RawType.php | Added parameter and return types to conversion methods |
| src/Types/ObjectIdType.php | Added parameter and return types to conversion and version methods |
| src/Types/KeyType.php | Added parameter and return types with proper union types |
| src/Types/IntType.php | Added parameter and return types to all methods |
| src/Types/Int64Type.php | Added parameter and return types, removed redundant interface declarations |
| src/Types/IdType.php | Added parameter and return types to conversion methods |
| src/Types/HashType.php | Added parameter and return types with PHPDoc annotations |
| src/Types/FloatType.php | Added parameter and return types to all methods |
| src/Types/Decimal128Type.php | Added parameter and return types, removed redundant PHPDoc |
| src/Types/DateType.php | Added parameter and return types to all methods |
| src/Types/DateImmutableType.php | Narrowed return type to DateTimeImmutable, removed redundant PHPDoc |
| src/Types/CustomIdType.php | Added parameter and return types to conversion methods |
| src/Types/CollectionType.php | Added parameter and return types with PHPDoc for array structure |
| src/Types/BooleanType.php | Added parameter and return types to conversion methods |
| src/Types/BinDataType.php | Added parameter and return types to conversion methods |
| src/PersistentCollection/DefaultPersistentCollectionGenerator.php | Added union type for $fileName parameter |
| src/Mapping/ClassMetadataFactory.php | Added string type to parameter |
| src/Mapping/ClassMetadata.php | Added parameter types, removed redundant PHPDoc |
| src/Aggregation/Builder.php | Added readonly properties, union types for parameters, removed redundant property assignments |
| tests/Tests/Functional/DocumentPersisterTest.php | Added parameter and return types to custom type implementation |
| tests/Tests/Functional/CustomTypeTest.php | Added parameter and return types with PHPDoc for array structures |
| benchmark/BaseBench.php | Removed @BeforeMethods annotation, typed constants, added property types |
| benchmark/Document/StoreDocumentBench.php | Migrated to PHP attributes for PHPBench configuration |
| benchmark/Document/LoadDocumentBench.php | Migrated to PHP attributes, added property types |
| benchmark/Document/HydrateDocumentBench.php | Migrated to PHP attributes, added property types |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
IonBazan
force-pushed
the
types-stage-2
branch
from
93cc8dd to
260a585
Compare
GromNaN
reviewed
Dec 1, 2025
GromNaN
reviewed
Dec 1, 2025
IonBazan
force-pushed
the
types-stage-2
branch
from
1eddc42 to
2139929
Compare
IonBazan
force-pushed
the
types-stage-2
branch
from
2139929 to
2923dce
Compare
IonBazan
changed the title
GromNaN
reviewed
Dec 1, 2025
| ->equals('someValue'); | ||
|
|
||
| $stage = ['near' => [0, 0], 'spherical' => false, 'distanceField' => 'distance', 'query' => ['someField' => 'someValue']]; | ||
| $stage = ['near' => [0.0, 0.0], 'spherical' => false, 'distanceField' => 'distance', 'query' => ['someField' => 'someValue']]; |
Member
There was a problem hiding this comment.
Noted we convert the value to float with the arg type.
Co-authored-by: Jérôme Tamarelle <[email protected]>
GromNaN
approved these changes
Dec 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add types to
Typesnamespace and some leftovers in other places.