Skip to content

Conversation

moses197
Copy link

What Changed

  • Updated constructors in Api, Client, and Model files (including Configuration.php) with ?array $data = null to fix PHP deprecation warnings.
  • Added return types (bool, mixed, void) to improve type safety and compatibility.

Why It’s Needed

  • Fixes PHP deprecation warnings and ensures compatibility with modern PHP versions.
  • Enhances code clarity and maintainability.

Considerations

  • Fully backward-compatible with PHP versions that support nullable types and return type declarations.
  • Minimum PHP version requirements may need updating.

@WektorPriv
Copy link

Great, I have an issue right now based on those incompatibilities. Do you know maybe when it would be merged?

@moses197
Copy link
Author

Great, I have an issue right now based on those incompatibilities. Do you know maybe when it would be merged?

I don’t really know, but if you need any help, I’m happy to lend a hand

@moses197 moses197 requested a review from WektorPriv August 22, 2025 10:34
@moses197 moses197 force-pushed the v8.2.0-v2.1-25.1.00.02 branch from 643ff5c to b9f5dc7 Compare August 25, 2025 22:59
@luckykamon
Copy link

Thanks for this PR, when do you think the conflicts can be resolved so we can merge ?

@moses197
Copy link
Author

Thanks for this PR, when do you think the conflicts can be resolved so we can merge ?

I will do that now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants