Skip to content

fixes event fires doubled and adds contenteditable support #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fixes event fires doubled and adds contenteditable support #4

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8bc3aa9
Event fired twice due to keyup
andekande Apr 19, 2013
846fec7
add support for contenteditable
andekande Mar 6, 2015
4dd08ce
update to work inside of iframe body element
andekande Sep 9, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 26 additions & 10 deletions jquery.inputevent.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"input", "textInput",
"propertychange",
"paste", "cut",
"keydown", "keyup",
"keydown", /*"keyup",*/
"drop",
""].join(ns),
// Events required for delegate, mostly for IE support
Expand All @@ -35,7 +35,7 @@
};

$.event.special.txtinput = {
setup: function(data, namespaces, handler) {
setup: function(data, namespaces, handler, onChangeOnly) {
var timer,
bndCount,
// Get references to the element
Expand All @@ -50,7 +50,7 @@
$elem.bind(bindTo, handler);

$.data(elem, dataBnd, ++bndCount);
$.data(elem, dataVal, elem.value);
$.data(elem, dataVal, elem.value || elem.innerText || elem.textContent);
} else {
$elem.bind(dlgtTo, function (e) {
var target = e.target;
Expand All @@ -65,7 +65,7 @@
// make sure we increase the count only once for each bound ancestor
$.data(elem, dataDlg, true);
$.data(target, dataBnd, ++bndCount);
$.data(target, dataVal, target.value);
$.data(target, dataVal, target.value || target.innerText || elem.textContent);
}
});
}
Expand All @@ -83,29 +83,40 @@
if (e.type in delay && !timer) {
// ...so we need to delay them until after the event has fired
timer = window.setTimeout(function () {
if (elem.value !== $.data(elem, dataVal)) {
if ((elem.value !== undefined && elem.value !== $.data(elem, dataVal)) ||
(elem.value === undefined && elem.innerText !== undefined && elem.innerText !== $.data(elem, dataVal)) ||
(elem.value === undefined && elem.innerText === undefined && elem.textContent !== $.data(elem, dataVal))) {
$(elem).trigger("txtinput");
$.data(elem, dataVal, elem.value);
$.data(elem, dataVal, elem.value || elem.innerText || elem.textContent);
}
}, 0);
}
else if (e.type == "propertychange") {
if (e.originalEvent.propertyName == "value") {
$(elem).trigger("txtinput");
$.data(elem, dataVal, elem.value);
$.data(elem, dataVal, elem.value || elem.innerText || elem.textContent);
triggered = true;
window.setTimeout(function () {
triggered = false;
}, 0);
}
}
else {
var change = onChangeOnly !== undefined ? onChangeOnly :
$.fn.input.settings.onChangeOnly;
if ((elem.value !== undefined && $.data(elem, dataVal) === elem.value) ||
(elem.value === undefined && elem.innerText !== undefined && $.data(elem, dataVal) === elem.innerText) ||
(elem.value === undefined && elem.innerText === undefined && $.data(elem, dataVal) === elem.textContent)) {
if (change)
return;
}

$(elem).trigger("txtinput");
$.data(elem, dataVal, elem.value);
$.data(elem, dataVal, elem.value || elem.innerText || elem.textContent);
triggered = true;
window.setTimeout(function () {
triggered = false;
}, 0);
}, 0);
}
}
},
Expand All @@ -125,4 +136,9 @@
$.fn.input = function (handler) {
return handler ? $(this).bind("txtinput", handler) : this.trigger("txtinput");
}
})(jQuery);

$.fn.input.settings = {
onChangeOnly: false
};

})(jQuery);