Skip to content

Use instance options for deserializing in SystemTextJsonSerializer #406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use instance options for deserializing in SystemTextJsonSerializer #406

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/SocketIO.Serializer.SystemTextJson/SystemTextJsonSerializer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,7 @@ private SerializedItem SerializeEio4ConnectedMessage(string ns, object auth)

#region Read Message

private static void ReadMessage(IMessage message, EngineIO eio, string text)
private void ReadMessage(IMessage message, EngineIO eio, string text)
{
switch (message.Type)
{
Expand Down Expand Up @@ -343,11 +343,11 @@ private static void ReadMessage(IMessage message, EngineIO eio, string text)
}
}

private static void ReadOpenedMessage(IMessage message, string text)
private void ReadOpenedMessage(IMessage message, string text)
{
// TODO: Should deserializing to existing object
// But haven't support yet. https://github.com/dotnet/runtime/issues/78556
var newMessage = JsonSerializer.Deserialize<JsonMessage>(text, new JsonSerializerOptions
var newMessage = JsonSerializer.Deserialize<JsonMessage>(text, new JsonSerializerOptions(_options)
{
NumberHandling = JsonNumberHandling.AllowReadingFromString,
PropertyNamingPolicy = JsonNamingPolicy.CamelCase
Expand Down Expand Up @@ -543,4 +543,4 @@ private static void ReadBinaryAckMessage(IMessage message, string text)

#endregion
}
}
}
Loading