Use petsctools.attach_options
#217
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjward
approved these changes
Jul 16, 2025
JHopeCollins
changed the title
attach_options functions from petsctools.attach_options functions from petsctools.
JHopeCollins
changed the title
attach_options functions from petsctools.petsctools.attach_options
JHopeCollins
changed the title
petsctools.attach_optionspetsctools.attach_options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the
petsctools.attach_optionsand associated functions in the TAO solver.Also adds a "
tao" optional dependency set to the pyproject.toml includingpetsc4pyandpetsctools.The
attach_optionsfunctions are not in the current release ofpetsctoolsso this will have to wait until a new release is made, and means there's a minimum version restriction in the pyproject.toml.There is a lot of duplication with #214, which removes
OptionsManagerandflatten_optionsfrom the tao_solver file, but that PR is is compatible with the currentpetsctoolsrelease so can go in now.