Convert ROL interface to use AbstractReducedFunctional #223
+3
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angus-g
force-pushed
the
angus-g/rol-arf
branch
from
b824c01 to
2cb57ed
Compare
5 tasks
We recover the original behaviour by applying the Riesz map when returning the derivative or Hessian actions.
angus-g
force-pushed
the
angus-g/rol-arf
branch
from
2cb57ed to
726dbe3
Compare
|
I think this should be good to go (at least enough to restore functionality for us), I don't know if it should wait for firedrakeproject/firedrake#4581 or not? |
|
@angus-g I'm happy to see this merged. I've tested it in the PR for legacy dolfin-adjoint: dolfin-adjoint/dolfin-adjoint#38 and there it works. @dham shall we go ahead and merge this? |
jorgensd
approved these changes
Oct 9, 2025
These changes pass the new Firedrake test in the PR so they are clearly correct. I think it's fine to merge this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recover the original behaviour by applying the Riesz map when returning the derivative or Hessian actions. Maybe it would be better to provide a
.dual()method on the vector and let ROL decide which representation it wants? Probably also needs a test (e.g. on the Firedrake side)?