Import asc: Exclude nodata values for mesh creation#1020
Open
sito115 wants to merge 2 commits intodomlysz:masterfrom
Open
Import asc: Exclude nodata values for mesh creation#1020sito115 wants to merge 2 commits intodomlysz:masterfrom
sito115 wants to merge 2 commits intodomlysz:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried to work on the following "#TODO" comment for the operator for importing asc-files.
In my case, nodata filtering didn’t work because
nodatais declared asfloat,whilecoldata[x]was astrin my case, so the comparison returned False.To address this, I restructured the logic so that nodata vertices are kept initially, and any faces referencing a nodata vertex are removed later in the process.
This approach worked for my ASC file, but it still needs more testing to confirm that it behaves correctly across different datasets.