fix(compass): guard DeviceOrientationEvent lookup#420
Merged
KristjanESPERANTO merged 1 commit intodomoritz:gh-pagesfrom May 4, 2026
Merged
fix(compass): guard DeviceOrientationEvent lookup#420KristjanESPERANTO merged 1 commit intodomoritz:gh-pagesfrom
KristjanESPERANTO merged 1 commit intodomoritz:gh-pagesfrom
Conversation
Avoid ReferenceError in environments where orientation events may exist but the global DeviceOrientationEvent constructor is missing (e.g. Firefox/Linux variants). Add a regression test for the undefined-global case. Refs domoritz#419
KristjanESPERANTO
force-pushed
the
orientation
branch
from
a878ef6 to
deee373
Compare
domoritz
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some environments, orientation events are present in
windowbut theDeviceOrientationEventconstructor is not defined as a global - triggering aReferenceErrorwhen the compass is activated. This seems to affect a subset of Firefox users on Linux (reported with Firefox 149).The fix reads
DeviceOrientationEventsafely viawindowinstead of as a bare identifier, so the compass fails gracefully without breaking geolocation.Includes a regression test for this case.
Closes #419