Merged
Conversation
This commit completely removes the model override system from octohook. Changes: - Removed `model_overrides` parameter from setup() - Removed `_model_overrides` global variable - Removed BaseGithubModel.__new__ that checked for overrides - Deleted tests/test_model_override.py - Removed model override tests from test_setup.py and test_edge_cases.py - Removed "Model Overrides" section from README.md - Updated CLAUDE.md to remove model override documentation - Simplified setup() and reset() function signatures and docstrings Breaking change: Users who were using model_overrides will need to refactor their code to work without this feature. All 188 tests pass.
doodla
deleted the
claude/remove-model-override-system-011CUub96VELVJEneobxA9k3
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit completely removes the model override system from octohook.
It'll be readded in some other form after the migration to pydantic.