Support additional nmea messages #118
Conversation
PTNL is parent to e.g. AVR, BPQ, DG, EVT, GGK, PJK, PJT, VGK, VHD
…fullYear, month, day, hours, minutes, seconds, milliseconds, DateTimeKind.Utc)
dotMorten
left a comment
dotMorten
left a comment
There was a problem hiding this comment.
Dpt, Xdr and Hdt (the latter being deprecated) are the only ones part of the NMEA spec.
The others seem to rely on an odd Trimble pattern that I think would require some adjustments to the underlying library for how messages like that are being identified since they rely on multiple columns. I'm not really in favor of hardcoding those into the message parser, but would prefer you first open an discussing the need for parsing messages like that, and then probably keep these messages locally as message extensions in the application and not in the NMEA library itself.
| /// </para> | ||
| /// </remarks> | ||
| [System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.Naming", "CA1704:IdentifiersShouldBeSpelledCorrectly", MessageId = "HeHdt")] | ||
| [NmeaMessageType("--HDT")] |
There was a problem hiding this comment.
According to the NMEA spec HDT is a deprecated message
There was a problem hiding this comment.
Do you which me to revert it?
I can just create it locally in my project if you think it should not be part of this library.
| [TestMethod] | ||
| public void TestDPT() | ||
| { | ||
| string input = "$--DPT,149.5,000.5,1000.0*7F"; |
There was a problem hiding this comment.
Is this really how a real world message looks with the -- prefix and no talker-id?
I agree with your reasoning. PTNL,GGK and AML,SVM are different since they rely on the two first part of the message in order to identify what kind of message it is. I will remove them from this PR. |
2 participants
Write parsers and tests for new NMEA messages: