Skip to content

fix(typescript-urql-graphcache): improve typing #1110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dargmuesli
Copy link
Contributor

@dargmuesli dargmuesli commented May 23, 2025

Description

Linting typescript-urql-graphcache's output file showed some room for improvement, so this PR resolves a duplicate import source and improves typing for "empty object".

Related # (issue)

#1109
#445

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)
  • This change requires a documentation update

Screenshots/Sandbox (if appropriate/relevant):

n/a

How Has This Been Tested?

  • existing test snapshots have been updated

Checklist:

  • I have followed the
    CONTRIBUTING doc and the
    style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Further comments

n/a

Copy link

changeset-bot bot commented May 23, 2025

🦋 Changeset detected

Latest commit: 30ee6e8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@graphql-codegen/typescript-urql-graphcache Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dargmuesli dargmuesli changed the title fix(types): simplify fix(typescript-urql-graphcache): improve typing May 23, 2025
@dargmuesli
Copy link
Contributor Author

let me kindly cc last editors of the changed line @beerose and @JoviDeCroock for review if time allows

- resolve a duplicate import
- improve typing for "empty object"
- respect `defaultScalarType`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant