-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated stylesheets.js adding local() property with Paul Irish smiley… #51
base: master
Are you sure you want to change the base?
Conversation
@@ -70,7 +72,8 @@ function scss(stylesheet, name, filename, weight, style, woff2, woff, ttf, svg, | |||
'@font-face {', | |||
` font-family: "${name}";`, | |||
` src: url("${filename}.eot");`, | |||
` src: url("${filename}.eot?#iefix") format("embedded-opentype"),`, | |||
` src: local("☺︎"),`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strings must use singlequote quotes
` url("${filename}.eot?#iefix") format("embedded-opentype"),`, | ||
` url(${woff2}) format("woff2"),`, | ||
` url(${woff}) format("woff"),`, | ||
` url(${ttf}) format("ttf"),`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Expected indentation of 4 spaces but found 6 indent
` src: local("☺︎"),`, | ||
` url("${filename}.eot?#iefix") format("embedded-opentype"),`, | ||
` url(${woff2}) format("woff2"),`, | ||
` url(${woff}) format("woff"),`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Expected indentation of 4 spaces but found 6 indent
` src: url("${filename}.eot");`, | ||
` src: local("☺︎"),`, | ||
` url("${filename}.eot?#iefix") format("embedded-opentype"),`, | ||
` url(${woff2}) format("woff2"),`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Expected indentation of 4 spaces but found 6 indent
` font-family: "${name}";`, | ||
` src: url("${filename}.eot");`, | ||
` src: local("☺︎"),`, | ||
` url("${filename}.eot?#iefix") format("embedded-opentype"),`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Expected indentation of 4 spaces but found 6 indent
` src: url("${filename}.eot");`, | ||
` src: local("☺︎"),`, | ||
` url("${filename}.eot?#iefix") format("embedded-opentype"),`, | ||
` url(${woff2}) format("woff2"),`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Expected indentation of 4 spaces but found 6 indent
` font-family: "${name}";`, | ||
` src: url("${filename}.eot");`, | ||
` src: local("☺︎"),`, | ||
` url("${filename}.eot?#iefix") format("embedded-opentype"),`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Expected indentation of 4 spaces but found 6 indent
'@font-face {', | ||
` font-family: "${name}";`, | ||
` src: url("${filename}.eot");`, | ||
` src: local("☺︎"),`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Expected indentation of 4 spaces but found 6 indent
Strings must use singlequote quotes
` url(${ttf}) format("ttf"),`, | ||
'@font-face {', | ||
` font-family: "${name}";`, | ||
` src: url("${filename}.eot");`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Expected indentation of 4 spaces but found 6 indent
` url(${woff}) format("woff"),`, | ||
` url(${ttf}) format("ttf"),`, | ||
'@font-face {', | ||
` font-family: "${name}";`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Expected indentation of 4 spaces but found 6 indent
… varation
See: https://www.paulirish.com/2009/bulletproof-font-face-implementation-syntax/#smiley