Skip to content

chore: Add retry for curl that download dotnet-install.sh/ps1 #2983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
filzrev wants to merge 3 commits into
base: master
Choose a base branch
from
+8 −20
Open

chore: Add retry for curl that download dotnet-install.sh/ps1 #2983

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d7f7c78
chore: add retry for curl that download dotnet-install.sh
filzrev Jan 27, 2026
f87af3f
chore: modify build scripts to use powershell core
filzrev Jan 28, 2026
a731881
chore: remove dead code
filzrev Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion build/build.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,9 @@ if ($PSVersionTable.PSEdition -ne 'Core') {
}
}

# Temporary remove curl alias.
Remove-Item alias:curl

###########################################################################
# INSTALL .NET CORE CLI
###########################################################################
Expand Down Expand Up @@ -55,7 +58,9 @@ $GlobalJsonPath = Join-Path $SdkPath "global.json"
if (!(Test-Path $InstallPath)) {
New-Item -Path $InstallPath -ItemType Directory -Force | Out-Null;
$ScriptPath = Join-Path $InstallPath 'dotnet-install.ps1'
(New-Object System.Net.WebClient).DownloadFile($DotNetInstallerUri, $ScriptPath);

curl -LsSfo $ScriptPath $DotNetInstallerUri --retry 5 --retry-delay 5

& $ScriptPath -JSonFile $GlobalJsonPath -InstallDir $InstallPath;

# Install .NET 8 SDK
Expand Down
2 changes: 1 addition & 1 deletion build/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ export DOTNET_SYSTEM_NET_HTTP_USESOCKETSHTTPHANDLER=0

if [ ! -d "$PROJECT_ROOT/.dotnet" ]; then
mkdir "$PROJECT_ROOT/.dotnet"
curl -Lsfo "$PROJECT_ROOT/.dotnet/dotnet-install.sh" https://dot.net/v1/dotnet-install.sh
curl -LsSfo "$PROJECT_ROOT/.dotnet/dotnet-install.sh" https://dot.net/v1/dotnet-install.sh --retry 5 --retry-delay 5
bash "$PROJECT_ROOT/.dotnet/dotnet-install.sh" --jsonfile ./build/sdk/global.json --install-dir .dotnet --no-path

# Install .NET 8 SDK
Expand Down
Loading