Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website rework #2272

Closed
wants to merge 13 commits into from
Closed

Website rework #2272

wants to merge 13 commits into from

Conversation

lumi2021
Copy link
Contributor

The Silk.NET website remade from scratch

As requested by Perksey, it is now built on Docusaurus. It style is completely made from scratch based on the current one.

To run the project:

  • Make sure Node.js and NPM are installed and up to date;
  • Make sure you have the last version of the fork;
  • Run the nuke command with "website"

Unfortunately, Docusaurus uses git history information to set doc page's author, so I'm the author of everything now lol. It can be solved only if the respective authors do some changes on their .md files.

Any issues, questions or anything, pls comment here.

Perksey-senpai pls accept my PR 👉👈😖

@lumi2021 lumi2021 requested a review from a team as a code owner August 18, 2024 21:57
@Perksey
Copy link
Member

Perksey commented Aug 18, 2024

Unfortunately, Docusaurus uses git history information to set doc page's author, so I'm the author of everything now lol. It can be solved only if the respective authors do some changes on their .md files.

I'll try and sort this out if accepted.

@Perksey
Copy link
Member

Perksey commented Aug 18, 2024

Is this ready for review?

Target Website => _ => _
.Executes(() =>
{
Console.WriteLine("Verifying dependences:\n");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dependencies

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And also the related method

@lumi2021
Copy link
Contributor Author

Is this ready for review?
@Perksey

uhhh... yeah? what is the problem?

@Perksey
Copy link
Member

Perksey commented Sep 1, 2024

I'm closing this PR. Too many of the review comments on the last PR have not been addressed such that this would take too much time to review, and too much time to fix ourselves. I think this work item has exhausted the amount of time the team is able to dedicate towards it. We may pick this back up in the future.

@Perksey Perksey closed this Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants