-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manual updates 20250318 nuget.config for new pipelines #1112
base: main
Are you sure you want to change the base?
Conversation
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the NuGet configuration and build scripts to support new pipeline requirements by manually downloading NuGet packages and cleaning them up post-build. Key changes include:
- Introduces a new Cake task in nuget-install.cake for downloading necessary NuGet packages.
- Adds cleanup steps in build-and-package.cake to remove NuGet packages from the output directory.
- Updates utilities.cake and binderate.cake with new package versions and directory setup.
Reviewed Changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
File | Description |
---|---|
build/cake/nuget-install.cake | New Cake task for manually downloading NuGet packages. |
build/cake/build-and-package.cake | Adds deletion of downloaded packages to prevent CI validation issues. |
build.cake | Loads and runs the new nuget-install task. |
utilities.cake | Upgrades package versions and includes commented-out alternative addin declarations. |
build/cake/binderate.cake | Ensures the output directory exists for binderate use. |
Files not reviewed (2)
- NuGet.config: Language not supported
- tests/common/NuGet.config: Language not supported
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This breaks all of our unit tests, example:
NU1100: Unable to resolve 'Microsoft.NET.ILLink.Tasks (>= 8.0.14)' for 'net8.0-android34.0'. PackageSourceMapping is enabled, the following source(s) were not considered: C:\ToolCache\dotnet\library-packs, darc-pub-dotnet-android-82d8938, darc-pub-dotnet-android-e7876a4, darc-pub-dotnet-emsdk-91b783e, darc-pub-dotnet-runtime-ef07c4f, dotnet-eng, dotnet-public, dotnet-tools, dotnet10, dotnet10-transport, dotnet9, dotnet9-transport, Local Output, xamarin.android util.
NU1100: Unable to resolve 'Microsoft.NET.ILLink.Tasks (>= 8.0.14)' for 'net8.0-android34.0/android-arm'. PackageSourceMapping is enabled, the following source(s) were not considered: C:\ToolCache\dotnet\library-packs, darc-pub-dotnet-android-82d8938, darc-pub-dotnet-android-e7876a4, darc-pub-dotnet-emsdk-91b783e, darc-pub-dotnet-runtime-ef07c4f, dotnet-eng, dotnet-public, dotnet-tools, dotnet10, dotnet10-transport, dotnet9, dotnet9-transport, Local Output, xamarin.android util.
NU1100: Unable to resolve 'Microsoft.NET.ILLink.Tasks (>= 8.0.14)' for 'net8.0-android34.0/android-arm64'. PackageSourceMapping is enabled, the following source(s) were not considered: C:\ToolCache\dotnet\library-packs, darc-pub-dotnet-android-82d8938, darc-pub-dotnet-android-e7876a4, darc-pub-dotnet-emsdk-91b783e, darc-pub-dotnet-runtime-ef07c4f, dotnet-eng, dotnet-public, dotnet-tools, dotnet10, dotnet10-transport, dotnet9, dotnet9-transport, Local Output, xamarin.android util.
NU1100: Unable to resolve 'Microsoft.NET.ILLink.Tasks (>= 8.0.14)' for 'net8.0-android34.0/android-x64'. PackageSourceMapping is enabled, the following source(s) were not considered: C:\ToolCache\dotnet\library-packs, darc-pub-dotnet-android-82d8938, darc-pub-dotnet-android-e7876a4, darc-pub-dotnet-emsdk-91b783e, darc-pub-dotnet-runtime-ef07c4f, dotnet-eng, dotnet-public, dotnet-tools, dotnet10, dotnet10-transport, dotnet9, dotnet9-transport, Local Output, xamarin.android util.
NU1100: Unable to resolve 'Microsoft.NET.ILLink.Tasks (>= 8.0.14)' for 'net8.0-android34.0/android-x86'. PackageSourceMapping is enabled, the following source(s) were not considered: C:\ToolCache\dotnet\library-packs, darc-pub-dotnet-android-82d8938, darc-pub-dotnet-android-e7876a4, darc-pub-dotnet-emsdk-91b783e, darc-pub-dotnet-runtime-ef07c4f, dotnet-eng, dotnet-public, dotnet-tools, dotnet10, dotnet10-transport, dotnet9, dotnet9-transport, Local Output, xamarin.android util.
I'm also not sure we actually want to make this change. If we stick to publicly released preview versions of .NET 10, do we need to do all of this extra work?
cc: @jonathanpeppers ^^
What is this PR trying to do? I'm not following why you need a copy of dotnet/android's From the discussion here, I thought you should use NuGet.org and that's it? |
Workaround for security policies. This is new pipeline and has some restrictions we didn't have before. Few minutes ago I added back: <add key="nuget.org" value="https://api.nuget.org/v3/index.json" /> and as result I get:
Link: That is the reason I used dotnet/android's
There is no
For There is much much more Our tests fail locally with:
It is because test use CliWrap to create app If I run
There is also cake script that downloads few nugets I was not able to migrate to internal feeds. Namely some packages are whitelisted and some are not. I hope this shines some light. |
This has nothing to do with .NET 10. Simply security policies for new pipelines. |
Nuget.config
fromdotnet/android
for repo builds