Add new Google Maven artifacts to config.json and remove problematic proto namespaces #1243
+345
−113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copilot
AI
changed the title
Copilot finished work on behalf of
mattleibow
August 7, 2025 23:13
|
@copilot Please commit all the PublicAPI files |
I've committed all the PublicAPI files along with the required org.json dependency. Created PublicAPI directories and files for:
Also added the missing org.json:json dependency to config.json which was required by the localagents artifacts. All files committed in 93b8e30. |
Copilot
AI
changed the title
Copilot finished work on behalf of
mattleibow
August 7, 2025 23:41
|
@copilot Please commit all the PublicAPI files |
All PublicAPI files have already been committed in 93b8e30. The commit includes all required PublicAPI files for the new Google AI Edge LocalAgents and MediaPipe artifacts:
The working tree is clean with no additional PublicAPI files to commit. |
Copilot finished work on behalf of
mattleibow
August 7, 2025 23:54
mattleibow
reviewed
Aug 8, 2025
mattleibow
reviewed
Aug 8, 2025
mattleibow
reviewed
Aug 8, 2025
mattleibow
reviewed
Aug 8, 2025
mattleibow
reviewed
Aug 8, 2025
|
@copilot there are some build errors: |
... Fixed the build errors by adding explicit interface implementations in the Additions file. The issue was that the concrete classes |
Copilot
AI
changed the title
Copilot finished work on behalf of
mattleibow
August 8, 2025 18:54
|
@copilot Now that the changes are made, there should be re-generated PublicAPI files. PLease commit the new chanmges as well. |
The build process is running to regenerate the PublicAPI files after the interface implementation fixes. The |
Copilot finished work on behalf of
mattleibow
August 8, 2025 20:00
Copilot finished work on behalf of
mattleibow
August 8, 2025 20:51
We can now use a modern Java to build the native libraries.
This reverts commit a76a334.
This reverts commit fa09d98.
Co-authored-by: mattleibow <[email protected]>
…ogle AI Edge and MediaPipe artifacts Co-authored-by: mattleibow <[email protected]>
Co-authored-by: mattleibow <[email protected]>
Co-authored-by: mattleibow <[email protected]>
mattleibow
force-pushed
the
copilot/fix-53d65152-bc63-44c7-86ac-bcee20ee7e5a
branch
from
0b99f15 to
72b59b1
Compare
|
@copilot I see some build errors: Can you remove the |
Co-authored-by: mattleibow <[email protected]>
... Fixed the build errors by creating metadata transforms to remove the problematic proto namespaces from both localagents bindings. Added Metadata.xml files that remove: For localagents-fc:
For localagents-rag:
These internal proto types were causing interface implementation conflicts similar to the MediaPipe tasks-genai binding. The transforms eliminate these internal packages from the generated bindings. Changes committed in 5e4a5ed. |
Copilot
AI
changed the title
Copilot finished work on behalf of
mattleibow
August 11, 2025 17:11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds three new Google Maven artifacts to the
config.jsonconfiguration file to enable .NET for Android bindings for new Google AI and MediaPipe libraries, along with their required dependencies and necessary binding fixes.Added Artifacts
Google AI Edge LocalAgents
Xamarin.Google.AI.Edge.LocalAgents.FCXamarin.Google.AI.Edge.LocalAgents.RAGGoogle MediaPipe Tasks
Xamarin.Google.MediaPipe.Tasks.GenAIDependencies and Fixes
The
org.json:jsondependency required by the localagents artifacts has been excluded viaexcludedRuntimeDependenciesto prevent packaging conflicts, as this library is already available in the Android runtime.All internal proto namespaces have been removed from the bindings using metadata transforms to resolve compilation errors. These proto classes are internal implementation details that were causing interface implementation conflicts:
com.google.mediapipe.tasks.genai.llminference.jni.protonamespacecom.google.ai.edge.localagents.core.protoandcom.google.ai.edge.localagents.fc.protonamespacescom.google.ai.edge.localagents.rag.memory.protoandcom.google.ai.edge.localagents.rag.models.protonamespacesThe metadata transforms use
remove-nodedirectives to eliminate these internal packages from the generated bindings, preventing CS0535 errors where concrete classes failed to implement interface members correctly.All artifacts follow the established config.json format with proper NuGet ID casing and are positioned correctly in alphabetical order within their respective groupId sections. PublicAPI files have been created for all new bindings following repository conventions.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.