Adding using RabbitMq worker, simple chaos, telemetry propagation #671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dankoverride
commented
Jan 29, 2025
dankoverride
commented
- Upstream support OTel support
- Introduced random chaos
- Adding rabbit.
- Worker and ActivitySource wireup with Rabbit
* Upstream support OTel support * Introduced random chaos * Adding rabbit. * Worker and ActivitySource wireup with Rabbit
|
|
There was a problem hiding this comment.
Copilot reviewed 11 out of 26 changed files in this pull request and generated 2 comments.
Files not reviewed (15)
- samples/AspireShop/AspireShop.AppHost/AspireShop.AppHost.csproj: Language not supported
- samples/AspireShop/AspireShop.BasketBus/AspireShop.BasketBus.csproj: Language not supported
- samples/AspireShop/AspireShop.BasketService/AspireShop.BasketService.csproj: Language not supported
- samples/AspireShop/AspireShop.BasketService/appsettings.Development.json: Language not supported
- samples/AspireShop/AspireShop.BasketWorker/AspireShop.BasketWorker.csproj: Language not supported
- samples/AspireShop/AspireShop.BasketWorker/Properties/launchSettings.json: Language not supported
- samples/AspireShop/AspireShop.BasketWorker/appsettings.Development.json: Language not supported
- samples/AspireShop/AspireShop.BasketWorker/appsettings.json: Language not supported
- samples/AspireShop/AspireShop.Chaos/AspireShop.Chaos.csproj: Language not supported
- samples/AspireShop/AspireShop.Frontend/AspireShop.Frontend.csproj: Language not supported
- samples/AspireShop/AspireShop.AppHost/Program.cs: Evaluated as low risk
- samples/AspireShop/AspireShop.BasketBus/BasicBus.cs: Evaluated as low risk
- samples/AspireShop/AspireShop.BasketBus/BasicConsumer.cs: Evaluated as low risk
- samples/AspireShop/AspireShop.BasketService/BasketService.cs: Evaluated as low risk
- samples/AspireShop/AspireShop.BasketService/Program.cs: Evaluated as low risk
Comments suppressed due to low confidence (1)
samples/AspireShop/AspireShop.Chaos/ChaosProvider.cs:18
- [nitpick] The method name 'PonderChaosAsync' is ambiguous. Consider renaming it to something more descriptive like 'IntroduceRandomChaosAsync'.
public Task PonderChaosAsync()
Comment on lines
+28
to
+30
| if (new Random(Guid.NewGuid().GetHashCode()).Next(0, 100) == 0) | ||
| { | ||
| throw new Exception("Random Chaos"); |
There was a problem hiding this comment.
The exception message 'Random Chaos' is not very descriptive. Consider providing more context in the message.
Suggested change
| if (new Random(Guid.NewGuid().GetHashCode()).Next(0, 100) == 0) | |
| { | |
| throw new Exception("Random Chaos"); | |
| int randomValue = new Random(Guid.NewGuid().GetHashCode()).Next(0, 100); | |
| if (randomValue == 0) | |
| { | |
| throw new Exception($"Random Chaos occurred with random value: {randomValue}"); |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
| await _chaosProvider.PonderChaosAsync(); | ||
|
|
||
| // Simulate some work | ||
| Thread.Sleep(1000); |
There was a problem hiding this comment.
Using Thread.Sleep in an async method can block the thread. Replace it with await Task.Delay(1000);
Suggested change
| Thread.Sleep(1000); | |
| await Task.Delay(1000); |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.