Endpoint renderer waits for quiescence with stopping the rendering #62524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arlierst possible + make sure navigation enhancement callbacks are available by using a promise.
Revert fully fixes to `NotFoundSetOnFormSubmit_ResponseNotStarted_SSR`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix SSR with
NotFoundtriggered after async operation startedDescription
NotFoundpage didn't get rendered ifNavigationManager.NotFound()got called after an async operation. It's because we are making sure nothing gets rendered after the current render batch. We are stopping the renderer after setting the 404 code. The Router was queueing rendering of 404 page after the "stop" signal.We used to test async operations with streaming enabled and no-streaming was tested with sync operations only. Test cases with
_AfterAsyncOperation_ResponseNotStarted_SSRwere added to cover POST and GET scenarios of this kind.To fix it, we changed the
SignalRendererToFinishRenderingmethods toRequestRendererToFinishRendering. Now, when setting the 404 code we only signal the need to stop the renderer in the future. Then, we stop it for real after the quiescence task is finished.Because we already observed a similar problem with POST requests, we were working that around by using fetch on the client to show 404 page in POSTs. In this PR we could remove the workaround and follow the same pattern as for GETs. This introduced a change in "NotFoundSetOnFormSubmit" tests. POST does not behave anymore as response started.
Fixes #62469