Skip to content

[9.0] Make duplicate deb/rpm packages so we can sign them with the new PMC key #63249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: release/9.0
Choose a base branch
from
Open

[9.0] Make duplicate deb/rpm packages so we can sign them with the new PMC key #63249

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Installers/Debian/Directory.Build.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,5 +60,6 @@
</PropertyGroup>

<Copy SourceFiles="$(IntermediateOutputPath)out/$(BuildScriptOutputFileName)" DestinationFiles="$(TargetPath)" />
Copy link
Preview

Copilot AI Aug 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The copy operation lacks consistency with the RPM implementation. Consider adding a message task similar to line 114 in the RPM Directory.Build.targets to provide feedback about the copy operation.

Suggested change
<Copy SourceFiles="$(IntermediateOutputPath)out/$(BuildScriptOutputFileName)" DestinationFiles="$(TargetPath)" />
<Copy SourceFiles="$(IntermediateOutputPath)out/$(BuildScriptOutputFileName)" DestinationFiles="$(TargetPath)" />
<Message Text="Copying $(IntermediateOutputPath)out/$(BuildScriptOutputFileName) to $(OutputPath)$(NewKeyTargetFileName)" Importance="high" />

Copilot uses AI. Check for mistakes.

<Copy SourceFiles="$(IntermediateOutputPath)out/$(BuildScriptOutputFileName)" DestinationFiles="$(OutputPath)$(NewKeyTargetFileName)" />
</Target>
</Project>
1 change: 1 addition & 0 deletions src/Installers/Debian/Runtime/Debian.Runtime.debproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@

<PropertyGroup>
<TargetFileName>$(RuntimeInstallerBaseName)-$(SharedFxVersion)-x64.deb</TargetFileName>
<NewKeyTargetFileName>$(RuntimeInstallerBaseName)-$(SharedFxVersion)-newkey-x64.deb</NewKeyTargetFileName>
<TargetPath>$(TargetDir)$(TargetFileName)</TargetPath>
<!-- DebPackageVersion does not match the ASP.NET Core runtime verison. -->
<DebPackageVersion>$(VersionPrefix)</DebPackageVersion>
Expand Down
1 change: 1 addition & 0 deletions src/Installers/Debian/TargetingPack/Debian.TargetingPack.debproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@

<PropertyGroup>
<TargetFileName>$(TargetingPackInstallerBaseName)-$(TargetingPackVersion)-$(TargetArchitecture).deb</TargetFileName>
<NewKeyTargetFileName>$(TargetingPackInstallerBaseName)-$(TargetingPackVersion)-newkey-$(TargetArchitecture).deb</NewKeyTargetFileName>
<TargetPath>$(TargetDir)$(TargetFileName)</TargetPath>

<DebPackageVersion>$(TargetingPackVersionPrefix)</DebPackageVersion>
Expand Down
1 change: 1 addition & 0 deletions src/Installers/Rpm/Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@

<CblMariner1VersionSuffix>-cm.1</CblMariner1VersionSuffix>
<CblMariner2VersionSuffix>-cm.2</CblMariner2VersionSuffix>
<NewKeyVersionSuffix>-newkey</NewKeyVersionSuffix>

<!-- All installers are shipping assets. -->
<IsShipping>true</IsShipping>
Expand Down
9 changes: 9 additions & 0 deletions src/Installers/Rpm/Directory.Build.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@
<PropertyGroup>
<CblMariner1TargetPath>$(InstallersOutputPath)$(CblMarinerBaseName)$(CblMariner1VersionSuffix)$(CblMarinerExtension)</CblMariner1TargetPath>
<CblMariner2TargetPath>$(InstallersOutputPath)$(CblMarinerBaseName)$(CblMariner2VersionSuffix)$(CblMarinerExtension)</CblMariner2TargetPath>
<NewKeyTargetPath>$(InstallersOutputPath)$(NewKeyBaseName)$(NewKeyVersionSuffix)$(NewKeyExtension)</NewKeyTargetPath>
</PropertyGroup>

<!-- Create layout: Create changelog -->
Expand Down Expand Up @@ -103,5 +104,13 @@
UseHardlinksIfPossible="False" />

<Message Text="$(TargetPath) -> $(CblMariner2TargetPath)" Importance="high" />

<Copy SourceFiles="$(TargetPath)"
DestinationFiles="$(NewKeyTargetPath)"
OverwriteReadOnlyFiles="True"
SkipUnchangedFiles="False"
UseHardlinksIfPossible="False" />

<Message Text="$(TargetPath) -> $(NewKeyTargetPath)" Importance="high" />
</Target>
</Project>
2 changes: 2 additions & 0 deletions src/Installers/Rpm/Runtime/Rpm.Runtime.rpmproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,7 @@
<TargetPath>$(InstallersOutputPath)$(TargetFileName)</TargetPath>
<CblMarinerBaseName>$(RuntimeInstallerBaseName)-$(SharedFxVersion)</CblMarinerBaseName>
<CblMarinerExtension>-$(RpmArch).rpm</CblMarinerExtension>
<NewKeyBaseName>$(RuntimeInstallerBaseName)-$(SharedFxVersion)</NewKeyBaseName>
<NewKeyExtension>-$(RpmArch).rpm</NewKeyExtension>
</PropertyGroup>
</Project>
2 changes: 2 additions & 0 deletions src/Installers/Rpm/TargetingPack/Rpm.TargetingPack.rpmproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@
<TargetPath>$(InstallersOutputPath)$(TargetFileName)</TargetPath>
<CblMarinerBaseName>$(TargetingPackInstallerBaseName)-$(TargetingPackVersion)</CblMarinerBaseName>
<CblMarinerExtension>-$(RpmArch).rpm</CblMarinerExtension>
<NewKeyBaseName>$(TargetingPackInstallerBaseName)-$(TargetingPackVersion)</NewKeyBaseName>
<NewKeyExtension>-$(RpmArch).rpm</NewKeyExtension>

<PackageVersion>$(TargetingPackVersionPrefix)</PackageVersion>

Expand Down
Loading