Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update files cloned from PerfView #3255

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cshung
Copy link
Member

@cshung cshung commented Aug 4, 2022

This is a work in progress.

My goal was to port these changes over, but I figured according to the documentation, the intent is to maintain a mirror, so I just copied all files over and see what happens.

No wonder - it won't compile - what should we do here?

@cshung cshung requested a review from a team as a code owner August 4, 2022 04:43
@cshung
Copy link
Member Author

cshung commented Aug 4, 2022

@brianrob. It appears that some changes are good to have (e.g. the very large graph support, the gen4 support). However, the new version accessed types cannot be accessed here. Do you have some idea what shall we do with that?

@brianrob
Copy link
Member

brianrob commented Aug 4, 2022

@cshung I don't recall why, but these files are copied from the perfview repo. There have been a number of changes that likely impact other files (e.g. there is a new type called SerializationConfiguration, a new enum called StreamLabelWidth). Perhaps it would be worth revisiting if the TraceEvent NuGet package can be used directly, or what it would take to get there. Alternatively, you'll have to go through each of these errors and figure out which files are missing - for example SerializationConfiguration is part of FastSerialization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants