-
Notifications
You must be signed in to change notification settings - Fork 6k
Added UWP to the .NET Implementations list #47097
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kel2v
wants to merge
1
commit into
dotnet:main
Choose a base branch
from
kel2v:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1
−0
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UWP is not the correct name to use here. The other doc is wrong as well. UWP Is Windows technology, not specific to .NET. .NET that runs on UWP is called .NET Native.
.NET Native is no longer developed, and we are encouraging users to migrate to .NET Core that runs on UWP as well.
Given that this is intro doc, I do not think it is an improvement to mention .NET Native and UWP in it. This list does not have to be complete.
Instead, I would delete the section about UWP from https://learn.microsoft.com/en-us/dotnet/fundamentals/implementations to resolve the issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @Sergio0694
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah this feels a bit off. The list is titled ".NET implementations", but the whole point of modern UWP is that it just uses the same .NET as everyone else. If we want to mention UWP (which I think doesn't hurt), I think it would be better and more accurate to just edit the previous item, so that it ends with:
Thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not entirely sure about that specific part, just because .NET Native is still officially supported for production, and receiving security updates. And there's still plenty of customers using it. If we removed it from there it might send the wrong message (i.e. that it's deprecated, which it isn't) perhaps?
Also cc. @tommcdon for that one since he owns it 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can leave out "supports" and just talk about main .NET implementations like in this doc.
Also, Microsoft does not support Mono anymore so that part is incorrect too.