Skip to content

Conversation

rcj1
Copy link

@rcj1 rcj1 commented Aug 25, 2025

Summary

  • Updated the UI in the dotnet-counters docs to reflect the more modern UI.
  • Removed dotnet-counters list and instead directed users to the appropriate Learn page.
  • Opened a PR in dotnet/diagnostics to indent tag sets such as those under gc.heap.generation data by an additional tab; this change is also reflected here in the docs.
    See dotnet-counters gc.heap.generation output diagnostics#4935

Internal previews

📄 File 🔗 Preview link
docs/core/diagnostics/debug-highcpu.md Debug high CPU usage in .NET Core
docs/core/diagnostics/debug-memory-leak.md Debug a memory leak tutorial
docs/core/diagnostics/debug-threadpool-starvation.md Debug ThreadPool starvation
docs/core/diagnostics/dotnet-counters.md Investigate performance counters (dotnet-counters)
docs/core/diagnostics/metrics-collection.md docs/core/diagnostics/metrics-collection
docs/core/diagnostics/metrics-instrumentation.md Creating metrics

@rcj1 rcj1 requested review from tommcdon and a team as code owners August 25, 2025 23:02
@dotnetrepoman dotnetrepoman bot added this to the August 2025 milestone Aug 25, 2025
@rcj1 rcj1 requested a review from noahfalk August 25, 2025 23:02
ThreadPool Queue Length 0
ThreadPool Thread Count 3
Working Set (MB) 30
System.Runtime
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Above the pre-reqs said .NET SDK 6.0. We should change that to 9.0 to match what is shown.

@@ -73,44 +73,64 @@ The live output should be similar to:

```console
Press p to pause, r to resume, q to quit.
Status: Running
Status: Running
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Above the pre-reqs say SDK 3.1. We should change that to SDK 9.0 since we are showing newer behavior.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If people use an older version it will still work with a different UI, correct? Then perhaps we should just leave it so as not to discourage people from trying just because they have an older SDK. We could add a note either here or up higher saying that with older SDKs your UI may look different, in fact we already will with my change.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If people use an older version it will still work with a different UI, correct?

Yep.

We could add a note either here or up higher saying that with older SDKs your UI may look different, in fact we already will with my change.

I'm good as long as somewhere we make it clear for the readers how to reproduce what the tutorial is showing. That sounds fine to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants