-
Notifications
You must be signed in to change notification settings - Fork 6k
Dotnet-counters docs updates w.r.t UI and list of counters #48111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
ThreadPool Queue Length 0 | ||
ThreadPool Thread Count 3 | ||
Working Set (MB) 30 | ||
System.Runtime |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Above the pre-reqs said .NET SDK 6.0. We should change that to 9.0 to match what is shown.
@@ -73,44 +73,64 @@ The live output should be similar to: | |||
|
|||
```console | |||
Press p to pause, r to resume, q to quit. | |||
Status: Running | |||
Status: Running |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Above the pre-reqs say SDK 3.1. We should change that to SDK 9.0 since we are showing newer behavior.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If people use an older version it will still work with a different UI, correct? Then perhaps we should just leave it so as not to discourage people from trying just because they have an older SDK. We could add a note either here or up higher saying that with older SDKs your UI may look different, in fact we already will with my change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If people use an older version it will still work with a different UI, correct?
Yep.
We could add a note either here or up higher saying that with older SDKs your UI may look different, in fact we already will with my change.
I'm good as long as somewhere we make it clear for the readers how to reproduce what the tutorial is showing. That sounds fine to me.
…to gh-diagnostics-4935
Co-authored-by: Noah Falk <[email protected]>
Summary
See dotnet-counters
gc.heap.generation
output diagnostics#4935Internal previews